content/browser/webui/web_ui_data_source_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/webui/web_ui_data_source_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/webui/web_ui_data_source_unittest.cc

diff --git a/content/browser/webui/web_ui_data_source_unittest.cc b/content/browser/webui/web_ui_data_source_unittest.cc

index 24d1d2b8f6d6f209d65be87fcdcb3a0a16145d7b..bece8d0fcddf4707bc923d6bb142639c9d9c9698 100644

--- a/content/browser/webui/web_ui_data_source_unittest.cc

+++ b/content/browser/webui/web_ui_data_source_unittest.cc

@@ -141,7 +141,7 @@ TEST_F(WebUIDataSourceTest, NamedResource) {

TEST_F(WebUIDataSourceTest, MimeType) {

const char* html = "text/html";

const char* js = "application/javascript";

- EXPECT_EQ(GetMimeType(""), html);

+ EXPECT_EQ(GetMimeType(std::string()), html);

EXPECT_EQ(GetMimeType("foo"), html);

EXPECT_EQ(GetMimeType("foo.html"), html);

EXPECT_EQ(GetMimeType(".js"), js);