Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: chrome/test/chromedriver/server/http_handler_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/keycode_text_conversion_x.cc ('k') | chrome/test/chromedriver/session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/server/http_handler_unittest.cc
diff --git a/chrome/test/chromedriver/server/http_handler_unittest.cc b/chrome/test/chromedriver/server/http_handler_unittest.cc
index d516902c15973fec03c9ef4d48c5be4ee10a91b7..a4d81a490923b591c4151858916b5c2ad71a8a60 100644
--- a/chrome/test/chromedriver/server/http_handler_unittest.cc
+++ b/chrome/test/chromedriver/server/http_handler_unittest.cc
@@ -56,7 +56,7 @@ TEST(HttpHandlerTest, HandleUnknownCommand) {
scoped_ptr<CommandExecutor>(new DummyExecutor()),
scoped_ptr<HttpHandler::CommandMap>(new HttpHandler::CommandMap()),
"/");
- HttpRequest request(kGet, "/path", "");
+ HttpRequest request(kGet, "/path", std::string());
HttpResponse response;
handler.Handle(request, &response);
ASSERT_EQ(HttpResponse::kNotFound, response.status());
@@ -68,7 +68,7 @@ TEST(HttpHandlerTest, HandleNewSession) {
HttpHandler handler(
scoped_ptr<CommandExecutor>(new DummyExecutor()),
map.Pass(), "/base/");
- HttpRequest request(kPost, "/base/session", "");
+ HttpRequest request(kPost, "/base/session", std::string());
HttpResponse response;
handler.Handle(request, &response);
ASSERT_EQ(HttpResponse::kSeeOther, response.status());
@@ -96,7 +96,7 @@ TEST(HttpHandlerTest, HandleUnimplementedCommand) {
HttpHandler handler(
scoped_ptr<CommandExecutor>(new DummyExecutor(kUnknownCommand)),
map.Pass(), "/");
- HttpRequest request(kPost, "/path", "");
+ HttpRequest request(kPost, "/path", std::string());
HttpResponse response;
handler.Handle(request, &response);
ASSERT_EQ(HttpResponse::kNotImplemented, response.status());
@@ -108,7 +108,7 @@ TEST(HttpHandlerTest, HandleCommand) {
HttpHandler handler(
scoped_ptr<CommandExecutor>(new DummyExecutor()),
map.Pass(), "/");
- HttpRequest request(kPost, "/path", "");
+ HttpRequest request(kPost, "/path", std::string());
HttpResponse response;
handler.Handle(request, &response);
ASSERT_EQ(HttpResponse::kOk, response.status());
@@ -140,9 +140,9 @@ TEST(MatchesCommandTest, DiffPathLength) {
ASSERT_FALSE(internal::MatchesCommand(
kPost, "path", command, &session_id, &params));
ASSERT_FALSE(internal::MatchesCommand(
- kPost, "", command, &session_id, &params));
- ASSERT_FALSE(internal::MatchesCommand(
- kPost, "/", command, &session_id, &params));
+ kPost, std::string(), command, &session_id, &params));
+ ASSERT_FALSE(
+ internal::MatchesCommand(kPost, "/", command, &session_id, &params));
ASSERT_FALSE(internal::MatchesCommand(
kPost, "path/path/path", command, &session_id, &params));
}
« no previous file with comments | « chrome/test/chromedriver/keycode_text_conversion_x.cc ('k') | chrome/test/chromedriver/session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698