chrome/common/extensions/permissions/socket_permission_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/socket_permission_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/permissions/socket_permission_unittest.cc

diff --git a/chrome/common/extensions/permissions/socket_permission_unittest.cc b/chrome/common/extensions/permissions/socket_permission_unittest.cc

index 6bb07be9087fad5ef6419cd205e17c886b16b886..05e7d3df3d2070fd157aef8e1836eb0e4c306d85 100644

--- a/chrome/common/extensions/permissions/socket_permission_unittest.cc

+++ b/chrome/common/extensions/permissions/socket_permission_unittest.cc

@@ -48,7 +48,7 @@ TEST_F(SocketPermissionTest, General) {

TEST_F(SocketPermissionTest, Parse) {

SocketPermissionData data;

- EXPECT_FALSE(data.ParseForTest(""));

+ EXPECT_FALSE(data.ParseForTest(std::string()));

EXPECT_FALSE(data.ParseForTest("*"));

EXPECT_FALSE(data.ParseForTest("\00\00*"));

EXPECT_FALSE(data.ParseForTest("\01*"));