chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

diff --git a/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc b/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

index ad00e117b9c9d383bebd36425b83b7a66a6c35a0..11af55a676b0f9b92cc7a87d1764c582f7e89706 100644

--- a/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

+++ b/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

@@ -315,7 +315,7 @@ dbus::Response* NativeBackendKWalletTest::KLauncherMethodCall(

scoped_ptr<dbus::Response> response(dbus::Response::CreateEmpty());

dbus::MessageWriter writer(response.get());

writer.AppendInt32(klauncher_ret_);

- writer.AppendString(""); // dbus_name

+ writer.AppendString(std::string()); // dbus_name

writer.AppendString(klauncher_error_);

writer.AppendInt32(1234); // pid

return response.release();

« no previous file with comments | « chrome/browser/password_manager/native_backend_kwallet_x.cc ('k') | chrome/browser/plugins/plugin_finder.cc » ('j') | no next file with comments »