Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5093)

Unified Diff: chrome/browser/extensions/api/alarms/alarms_api_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/alarms/alarms_api_unittest.cc
diff --git a/chrome/browser/extensions/api/alarms/alarms_api_unittest.cc b/chrome/browser/extensions/api/alarms/alarms_api_unittest.cc
index 60c367aa9ee5f5263f28434a2f12e0856989f858..34b4187fca07064cb4e48b81a646112cfefae044 100644
--- a/chrome/browser/extensions/api/alarms/alarms_api_unittest.cc
+++ b/chrome/browser/extensions/api/alarms/alarms_api_unittest.cc
@@ -151,7 +151,7 @@ TEST_F(ExtensionAlarmsTest, Create) {
CreateAlarm("[null, {\"delayInMinutes\": 0}]");
const Alarm* alarm =
- alarm_manager_->GetAlarm(extension_->id(), "");
+ alarm_manager_->GetAlarm(extension_->id(), std::string());
ASSERT_TRUE(alarm);
EXPECT_EQ("", alarm->js_alarm->name);
EXPECT_DOUBLE_EQ(10000, alarm->js_alarm->scheduled_time);
@@ -179,7 +179,7 @@ TEST_F(ExtensionAlarmsTest, CreateRepeating) {
CreateAlarm("[null, {\"periodInMinutes\": 0.001}]");
const Alarm* alarm =
- alarm_manager_->GetAlarm(extension_->id(), "");
+ alarm_manager_->GetAlarm(extension_->id(), std::string());
ASSERT_TRUE(alarm);
EXPECT_EQ("", alarm->js_alarm->name);
EXPECT_DOUBLE_EQ(10060, alarm->js_alarm->scheduled_time);
@@ -205,7 +205,7 @@ TEST_F(ExtensionAlarmsTest, CreateAbsolute) {
CreateAlarm("[null, {\"when\": 10001}]");
const Alarm* alarm =
- alarm_manager_->GetAlarm(extension_->id(), "");
+ alarm_manager_->GetAlarm(extension_->id(), std::string());
ASSERT_TRUE(alarm);
EXPECT_EQ("", alarm->js_alarm->name);
EXPECT_DOUBLE_EQ(10001, alarm->js_alarm->scheduled_time);
@@ -217,7 +217,7 @@ TEST_F(ExtensionAlarmsTest, CreateAbsolute) {
// MessageLoop when that happens.
MessageLoop::current()->Run();
- ASSERT_FALSE(alarm_manager_->GetAlarm(extension_->id(), ""));
+ ASSERT_FALSE(alarm_manager_->GetAlarm(extension_->id(), std::string()));
ASSERT_EQ(1u, alarm_delegate_->alarms_seen.size());
EXPECT_EQ("", alarm_delegate_->alarms_seen[0]);
@@ -228,7 +228,7 @@ TEST_F(ExtensionAlarmsTest, CreateRepeatingWithQuickFirstCall) {
CreateAlarm("[null, {\"when\": 10001, \"periodInMinutes\": 0.001}]");
const Alarm* alarm =
- alarm_manager_->GetAlarm(extension_->id(), "");
+ alarm_manager_->GetAlarm(extension_->id(), std::string());
ASSERT_TRUE(alarm);
EXPECT_EQ("", alarm->js_alarm->name);
EXPECT_DOUBLE_EQ(10001, alarm->js_alarm->scheduled_time);
@@ -240,13 +240,13 @@ TEST_F(ExtensionAlarmsTest, CreateRepeatingWithQuickFirstCall) {
// MessageLoop when that happens.
MessageLoop::current()->Run();
- ASSERT_TRUE(alarm_manager_->GetAlarm(extension_->id(), ""));
+ ASSERT_TRUE(alarm_manager_->GetAlarm(extension_->id(), std::string()));
EXPECT_THAT(alarm_delegate_->alarms_seen, testing::ElementsAre(""));
test_clock_.SetNow(base::Time::FromDoubleT(10.7));
MessageLoop::current()->Run();
- ASSERT_TRUE(alarm_manager_->GetAlarm(extension_->id(), ""));
+ ASSERT_TRUE(alarm_manager_->GetAlarm(extension_->id(), std::string()));
EXPECT_THAT(alarm_delegate_->alarms_seen, testing::ElementsAre("", ""));
}
« no previous file with comments | « chrome/browser/extensions/activity_log_unittest.cc ('k') | chrome/browser/extensions/api/bookmarks/bookmarks_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698