chrome/common/extensions/extension_icon_set_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_icon_set_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension_icon_set_unittest.cc

diff --git a/chrome/common/extensions/extension_icon_set_unittest.cc b/chrome/common/extensions/extension_icon_set_unittest.cc

index 1202cda17841150e6a609fd0160241b7e623a895..c7300a7b030abe62c0d52b8aacca3c4c5bae3d7b 100644

--- a/chrome/common/extensions/extension_icon_set_unittest.cc

+++ b/chrome/common/extensions/extension_icon_set_unittest.cc

@@ -62,7 +62,7 @@ TEST(ExtensionIconSet, Values) {

EXPECT_TRUE(icons.ContainsPath("foo"));

EXPECT_TRUE(icons.ContainsPath("bar"));

EXPECT_FALSE(icons.ContainsPath("baz"));

- EXPECT_FALSE(icons.ContainsPath(""));

+ EXPECT_FALSE(icons.ContainsPath(std::string()));

icons.Clear();

EXPECT_FALSE(icons.ContainsPath("foo"));

@@ -83,7 +83,7 @@ TEST(ExtensionIconSet, FindSize) {

EXPECT_EQ(extension_misc::EXTENSION_ICON_INVALID,

icons.GetIconSizeFromPath("baz"));

EXPECT_EQ(extension_misc::EXTENSION_ICON_INVALID,

- icons.GetIconSizeFromPath(""));

+ icons.GetIconSizeFromPath(std::string()));

icons.Clear();

EXPECT_EQ(extension_misc::EXTENSION_ICON_INVALID,