chrome/browser/prerender/prerender_histograms.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prerender/prerender_histograms.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/prerender/prerender_histograms.cc

diff --git a/chrome/browser/prerender/prerender_histograms.cc b/chrome/browser/prerender/prerender_histograms.cc

index d836cf828952f305bea1d1254139d7893042cc69..325c00e2e4f45fc69e1368b3cc80813318987546 100644

--- a/chrome/browser/prerender/prerender_histograms.cc

+++ b/chrome/browser/prerender/prerender_histograms.cc

@@ -92,9 +92,9 @@ bool OriginIsOmnibox(Origin origin) {

#define PREFIXED_HISTOGRAM_INTERNAL(origin, experiment, wash, HISTOGRAM, \

histogram_name) { \

{ \

- /* Do not rename. HISTOGRAM expects a local variable "name". */ \

- std::string name = ComposeHistogramName("", histogram_name); \

- HISTOGRAM; \

+ /* Do not rename. HISTOGRAM expects a local variable "name". */ \

+ std::string name = ComposeHistogramName(std::string(), histogram_name); \

+ HISTOGRAM; \

} \

/* Do not rename. HISTOGRAM expects a local variable "name". */ \

std::string name = GetHistogramName(origin, experiment, wash, \