chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_content/content_rules_registry.cc ('k') | chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc

diff --git a/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc b/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc

index 813b6b907247fd6f26f832e727ba00567416c77f..dc3beadccb619a8c8fcd8d67353a72c0964d2b02 100644

--- a/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc

+++ b/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc

@@ -56,7 +56,7 @@ IN_PROC_BROWSER_TEST_F(DeclarativeContentApiTest, Overview) {

tab, "document.body.innerHTML = '<input type=\"password\">';"));

// Give the mutation observer a chance to run and send back the

// matching-selector update.

- ASSERT_TRUE(content::ExecuteScript(tab, ""));

+ ASSERT_TRUE(content::ExecuteScript(tab, std::string()));

EXPECT_TRUE(page_action->GetIsVisible(tab_id));

// Remove it again to make sure that reverts the action.

@@ -64,7 +64,7 @@ IN_PROC_BROWSER_TEST_F(DeclarativeContentApiTest, Overview) {

tab, "document.body.innerHTML = 'Hello world';"));

// Give the mutation observer a chance to run and send back the

// matching-selector update.

- ASSERT_TRUE(content::ExecuteScript(tab, ""));

+ ASSERT_TRUE(content::ExecuteScript(tab, std::string()));

EXPECT_FALSE(page_action->GetIsVisible(tab_id));

}