Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2168)

Unified Diff: base/process_util_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/process_util_linux.cc ('k') | base/string_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process_util_unittest.cc
diff --git a/base/process_util_unittest.cc b/base/process_util_unittest.cc
index 265a2df41d7a756d33fe650294dbb76ca04e68d0..3ce99424f31ac10bfbef622f053304be55d01853 100644
--- a/base/process_util_unittest.cc
+++ b/base/process_util_unittest.cc
@@ -758,8 +758,8 @@ TEST_F(ProcessUtilTest, LaunchProcess) {
EXPECT_EQ(0, setenv("BASE_TEST", "testing", 1 /* override */));
EXPECT_EQ("testing\n", TestLaunchProcess(env_changes, no_clone_flags));
- env_changes.push_back(std::make_pair(std::string("BASE_TEST"),
- std::string("")));
+ env_changes.push_back(
+ std::make_pair(std::string("BASE_TEST"), std::string()));
EXPECT_EQ("\n", TestLaunchProcess(env_changes, no_clone_flags));
env_changes[0].second = "foo";
@@ -800,7 +800,7 @@ TEST_F(ProcessUtilTest, AlterEnvironment) {
delete[] e;
changes.clear();
- changes.push_back(std::make_pair(std::string("A"), std::string("")));
+ changes.push_back(std::make_pair(std::string("A"), std::string()));
e = base::AlterEnvironment(changes, empty);
EXPECT_TRUE(e[0] == NULL);
delete[] e;
@@ -819,7 +819,7 @@ TEST_F(ProcessUtilTest, AlterEnvironment) {
delete[] e;
changes.clear();
- changes.push_back(std::make_pair(std::string("A"), std::string("")));
+ changes.push_back(std::make_pair(std::string("A"), std::string()));
e = base::AlterEnvironment(changes, a2);
EXPECT_TRUE(e[0] == NULL);
delete[] e;
« no previous file with comments | « base/process_util_linux.cc ('k') | base/string_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698