net/proxy/proxy_resolver_v8_tracing_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_resolver_v8_tracing_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/proxy/proxy_resolver_v8_tracing_unittest.cc

diff --git a/net/proxy/proxy_resolver_v8_tracing_unittest.cc b/net/proxy/proxy_resolver_v8_tracing_unittest.cc

index b5503e574f281c1739f6a84749c5004f6ea8e4c0..5e0e108ca2df45d5ebbc0666a935c60c511943ef 100644

--- a/net/proxy/proxy_resolver_v8_tracing_unittest.cc

+++ b/net/proxy/proxy_resolver_v8_tracing_unittest.cc

@@ -282,7 +282,8 @@ TEST_F(ProxyResolverV8TracingTest, Dns) {

host_resolver.rules()->AddRuleForAddressFamily(

"host1", ADDRESS_FAMILY_IPV4, "166.155.144.44");

- host_resolver.rules()->AddIPLiteralRule("host1", "::1,192.168.1.1", "");

+ host_resolver.rules()

+ ->AddIPLiteralRule("host1", "::1,192.168.1.1", std::string());

host_resolver.rules()->AddSimulatedFailure("host2");

host_resolver.rules()->AddRule("host3", "166.155.144.33");

host_resolver.rules()->AddRule("host5", "166.155.144.55");

@@ -995,7 +996,8 @@ TEST_F(ProxyResolverV8TracingTest, MultipleResolvers) {

MockHostResolver host_resolver0;

host_resolver0.rules()->AddRuleForAddressFamily(

"host1", ADDRESS_FAMILY_IPV4, "166.155.144.44");

- host_resolver0.rules()->AddIPLiteralRule("host1", "::1,192.168.1.1", "");

+ host_resolver0.rules()

+ ->AddIPLiteralRule("host1", "::1,192.168.1.1", std::string());

host_resolver0.rules()->AddSimulatedFailure("host2");

host_resolver0.rules()->AddRule("host3", "166.155.144.33");

host_resolver0.rules()->AddRule("host5", "166.155.144.55");

« no previous file with comments | « net/proxy/dhcp_proxy_script_fetcher.cc ('k') | net/proxy/proxy_service_unittest.cc » ('j') | no next file with comments »