Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5749)

Unified Diff: chrome/common/extensions/extension_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_unittest.cc
diff --git a/chrome/common/extensions/extension_unittest.cc b/chrome/common/extensions/extension_unittest.cc
index 6a3c80d2ec02db4ad06f9e22212e1928dd7d0a09..edf24c45e222f73bc2747ff427b4b625fa3c7b54 100644
--- a/chrome/common/extensions/extension_unittest.cc
+++ b/chrome/common/extensions/extension_unittest.cc
@@ -233,16 +233,22 @@ TEST_F(ExtensionTest, MimeTypeSniffing) {
ASSERT_TRUE(file_util::ReadFileToString(path, &data));
std::string result;
- EXPECT_TRUE(net::SniffMimeType(data.c_str(), data.size(),
- GURL("http://www.example.com/foo.crx"), "", &result));
+ EXPECT_TRUE(net::SniffMimeType(data.c_str(),
+ data.size(),
+ GURL("http://www.example.com/foo.crx"),
+ std::string(),
+ &result));
EXPECT_EQ(std::string(Extension::kMimeType), result);
data.clear();
result.clear();
path = path.DirName().AppendASCII("bad_magic.crx");
ASSERT_TRUE(file_util::ReadFileToString(path, &data));
- EXPECT_TRUE(net::SniffMimeType(data.c_str(), data.size(),
- GURL("http://www.example.com/foo.crx"), "", &result));
+ EXPECT_TRUE(net::SniffMimeType(data.c_str(),
+ data.size(),
+ GURL("http://www.example.com/foo.crx"),
+ std::string(),
+ &result));
EXPECT_EQ("application/octet-stream", result);
}
« no previous file with comments | « chrome/common/extensions/extension_sync_type_unittest.cc ('k') | chrome/common/extensions/features/api_feature.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698