chrome/common/extensions/extension.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension.cc

diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc

index a94120886b5fbad43f2b727f252e992e71e5fd04..42407b8eb48cbf8c20d7f7881d913771beb73f78 100644

--- a/chrome/common/extensions/extension.cc

+++ b/chrome/common/extensions/extension.cc

@@ -437,8 +437,8 @@ bool Extension::ParsePermissions(const char* key,

if (manifest_->HasKey(key)) {

const ListValue* permissions = NULL;

if (!manifest_->GetList(key, &permissions)) {

- *error = ErrorUtils::FormatErrorMessageUTF16(

- errors::kInvalidPermissions, "");

+ *error = ErrorUtils::FormatErrorMessageUTF16(errors::kInvalidPermissions,

+ std::string());

return false;

}