chrome/browser/ssl/ssl_browser_tests.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ssl/ssl_browser_tests.cc

diff --git a/chrome/browser/ssl/ssl_browser_tests.cc b/chrome/browser/ssl/ssl_browser_tests.cc

index 42cfbf6e0d67818beae43ba84af6cc8b024614b0..d4afe0f84920398774e6b94866e2f50a25b2f676 100644

--- a/chrome/browser/ssl/ssl_browser_tests.cc

+++ b/chrome/browser/ssl/ssl_browser_tests.cc

@@ -738,9 +738,9 @@ IN_PROC_BROWSER_TEST_F(SSLUITest, MAYBE_TestHTTPSErrorWithNoNavEntry) {

IN_PROC_BROWSER_TEST_F(SSLUITest, TestBadHTTPSDownload) {

ASSERT_TRUE(test_server()->Start());

ASSERT_TRUE(https_server_expired_.Start());

- GURL url_non_dangerous = test_server()->GetURL("");

- GURL url_dangerous = https_server_expired_.GetURL(

- "files/downloads/dangerous/dangerous.exe");

+ GURL url_non_dangerous = test_server()->GetURL(std::string());

+ GURL url_dangerous =

+ https_server_expired_.GetURL("files/downloads/dangerous/dangerous.exe");

base::ScopedTempDir downloads_directory_;

// Need empty temp dir to avoid having Chrome ask us for a new filename