Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1642)

Unified Diff: remoting/protocol/jingle_messages.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/jingle_glue/xmpp_signal_strategy.cc ('k') | remoting/protocol/jingle_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/jingle_messages.cc
diff --git a/remoting/protocol/jingle_messages.cc b/remoting/protocol/jingle_messages.cc
index 7d8244375525d72f3ae746f7ba94d930743a8f6e..e2408e023a602efb326520afa7a374d54a0c2768 100644
--- a/remoting/protocol/jingle_messages.cc
+++ b/remoting/protocol/jingle_messages.cc
@@ -124,10 +124,9 @@ JingleMessage::NamedCandidate::NamedCandidate(
// static
bool JingleMessage::IsJingleMessage(const buzz::XmlElement* stanza) {
- return
- stanza->Name() == QName(kJabberNamespace, "iq") &&
- stanza->Attr(QName("", "type")) == "set" &&
- stanza->FirstNamed(QName(kJingleNamespace, "jingle")) != NULL;
+ return stanza->Name() == QName(kJabberNamespace, "iq") &&
+ stanza->Attr(QName(std::string(), "type")) == "set" &&
+ stanza->FirstNamed(QName(kJingleNamespace, "jingle")) != NULL;
}
// static
@@ -373,7 +372,7 @@ scoped_ptr<buzz::XmlElement> JingleMessageReply::ToXml(
std::string type;
std::string error_text;
- QName name("");
+ QName name;
switch (error_type) {
case BAD_REQUEST:
type = "modify";
« no previous file with comments | « remoting/jingle_glue/xmpp_signal_strategy.cc ('k') | remoting/protocol/jingle_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698