Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: remoting/host/log_to_server_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/host_port_allocator.cc ('k') | remoting/host/policy_hack/policy_watcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/log_to_server_unittest.cc
diff --git a/remoting/host/log_to_server_unittest.cc b/remoting/host/log_to_server_unittest.cc
index 1fb0500a3658efe163195381567f93b24ecf6e6b..99a51ecd6392ab1545f804d4b1b35af0634b564e 100644
--- a/remoting/host/log_to_server_unittest.cc
+++ b/remoting/host/log_to_server_unittest.cc
@@ -36,11 +36,12 @@ const char kHostJid[] = "host@domain.com/1234";
bool IsLogEntryForConnection(XmlElement* node, const char* connection_type) {
return (node->Name() == QName(kChromotingNamespace, "entry") &&
- node->Attr(QName("", "event-name")) == "session-state" &&
- node->Attr(QName("", "session-state")) == "connected" &&
- node->Attr(QName("", "role")) == "host" &&
- node->Attr(QName("", "mode")) == "me2me" &&
- node->Attr(QName("", "connection-type")) == connection_type);
+ node->Attr(QName(std::string(), "event-name")) == "session-state" &&
+ node->Attr(QName(std::string(), "session-state")) == "connected" &&
+ node->Attr(QName(std::string(), "role")) == "host" &&
+ node->Attr(QName(std::string(), "mode")) == "me2me" &&
+ node->Attr(QName(std::string(), "connection-type")) ==
+ connection_type);
}
MATCHER_P(IsClientConnected, connection_type, "") {
@@ -91,10 +92,10 @@ MATCHER_P2(IsTwoClientsConnected, connection_type1, connection_type2, "") {
bool IsLogEntryForDisconnection(XmlElement* node) {
return (node->Name() == QName(kChromotingNamespace, "entry") &&
- node->Attr(QName("", "event-name")) == "session-state" &&
- node->Attr(QName("", "session-state")) == "closed" &&
- node->Attr(QName("", "role")) == "host" &&
- node->Attr(QName("", "mode")) == "me2me");
+ node->Attr(QName(std::string(), "event-name")) == "session-state" &&
+ node->Attr(QName(std::string(), "session-state")) == "closed" &&
+ node->Attr(QName(std::string(), "role")) == "host" &&
+ node->Attr(QName(std::string(), "mode")) == "me2me");
}
MATCHER(IsClientDisconnected, "") {
« no previous file with comments | « remoting/host/host_port_allocator.cc ('k') | remoting/host/policy_hack/policy_watcher_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698