net/dns/mapped_host_resolver_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/mapped_host_resolver_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/dns/mapped_host_resolver_unittest.cc

diff --git a/net/dns/mapped_host_resolver_unittest.cc b/net/dns/mapped_host_resolver_unittest.cc

index 8da95e12c26e7aafc9ada2b5b0d85d85e88198eb..d8594663c9dd09b691f43483eaf6f2bfa1eec797 100644

--- a/net/dns/mapped_host_resolver_unittest.cc

+++ b/net/dns/mapped_host_resolver_unittest.cc

@@ -18,7 +18,7 @@ namespace {

std::string FirstAddress(const AddressList& address_list) {

if (address_list.empty())

- return "";

+ return std::string();

return address_list.front().ToString();

}

@@ -171,7 +171,7 @@ TEST(MappedHostResolverTest, ParseInvalidRules) {

new MappedHostResolver(scoped_ptr<HostResolver>()));

EXPECT_FALSE(resolver->AddRuleFromString("xyz"));

- EXPECT_FALSE(resolver->AddRuleFromString(""));

+ EXPECT_FALSE(resolver->AddRuleFromString(std::string()));

EXPECT_FALSE(resolver->AddRuleFromString(" "));

EXPECT_FALSE(resolver->AddRuleFromString("EXCLUDE"));

EXPECT_FALSE(resolver->AddRuleFromString("EXCLUDE foo bar"));

« no previous file with comments | « net/dns/host_resolver_impl_unittest.cc ('k') | net/dns/mock_host_resolver.cc » ('j') | no next file with comments »