Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: net/base/dns_util.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/webm/webm_cluster_parser_unittest.cc ('k') | net/base/host_mapping_rules_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/dns_util.cc
diff --git a/net/base/dns_util.cc b/net/base/dns_util.cc
index 816095b0bd8156c24532bc2d52682704a799d1a7..b94eff8980a492968033bda506b0c96f2586fa06 100644
--- a/net/base/dns_util.cc
+++ b/net/base/dns_util.cc
@@ -62,16 +62,16 @@ std::string DNSDomainToString(const base::StringPiece& domain) {
for (unsigned i = 0; i < domain.size() && domain[i]; i += domain[i] + 1) {
#if CHAR_MIN < 0
if (domain[i] < 0)
- return "";
+ return std::string();
#endif
if (domain[i] > 63)
- return "";
+ return std::string();
if (i)
ret += ".";
if (static_cast<unsigned>(domain[i]) + i + 1 > domain.size())
- return "";
+ return std::string();
domain.substr(i + 1, domain[i]).AppendToString(&ret);
}
« no previous file with comments | « media/webm/webm_cluster_parser_unittest.cc ('k') | net/base/host_mapping_rules_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698