chrome/browser/extensions/api/web_request/web_request_api_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_request/web_request_api_helpers.cc ('k') | chrome/browser/extensions/api/web_socket_proxy_private/web_socket_proxy_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

index 91e3dd9d3e694feb33a04a89d79b55b33d65dcce..fc78860babf1a768423788a30895bf2f3efd9536 100644

--- a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

@@ -574,9 +574,10 @@ TEST_F(ExtensionWebRequestTest, AccessRequestBodyData) {

keys::kRequestBodyRawBytesKey,

BinaryValue::CreateWithCopiedBuffer(kPlainBlock1, kPlainBlock1Length),

&raw);

- extensions::subtle::AppendKeyValuePair(keys::kRequestBodyRawFileKey,

- Value::CreateStringValue(""),

- &raw);

+ extensions::subtle::AppendKeyValuePair(

+ keys::kRequestBodyRawFileKey,

+ Value::CreateStringValue(std::string()),

+ &raw);

extensions::subtle::AppendKeyValuePair(

keys::kRequestBodyRawBytesKey,

BinaryValue::CreateWithCopiedBuffer(kPlainBlock2, kPlainBlock2Length),

@@ -962,7 +963,7 @@ void TestInitFromValue(const std::string& values, bool expected_return_code,

}

TEST_F(ExtensionWebRequestTest, InitFromValue) {

- TestInitFromValue("", true, 0);

+ TestInitFromValue(std::string(), true, 0);

// Single valid values.

TestInitFromValue(