Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10082)

Unified Diff: chrome/common/extensions/api/extension_api_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/api/extension_api.cc ('k') | chrome/common/extensions/csp_validator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/extension_api_unittest.cc
diff --git a/chrome/common/extensions/api/extension_api_unittest.cc b/chrome/common/extensions/api/extension_api_unittest.cc
index 98830ea5f8693fd0fd96d2874cbb78288ce44361..f980b576921734fc981cb60086bae8f150a61aa3 100644
--- a/chrome/common/extensions/api/extension_api_unittest.cc
+++ b/chrome/common/extensions/api/extension_api_unittest.cc
@@ -97,7 +97,7 @@ TEST_F(ExtensionAPITest, IsPrivileged) {
EXPECT_TRUE(extension_api->IsPrivileged("runtime.lastError"));
// Default unknown names to privileged for paranoia's sake.
- EXPECT_TRUE(extension_api->IsPrivileged(""));
+ EXPECT_TRUE(extension_api->IsPrivileged(std::string()));
EXPECT_TRUE(extension_api->IsPrivileged("<unknown-namespace>"));
EXPECT_TRUE(extension_api->IsPrivileged("extension.<unknown-member>"));
@@ -224,8 +224,8 @@ TEST(ExtensionAPI, APIFeatures) {
TEST_F(ExtensionAPITest, LazyGetSchema) {
scoped_ptr<ExtensionAPI> apis(ExtensionAPI::CreateWithDefaultConfiguration());
- EXPECT_EQ(NULL, apis->GetSchema(""));
- EXPECT_EQ(NULL, apis->GetSchema(""));
+ EXPECT_EQ(NULL, apis->GetSchema(std::string()));
+ EXPECT_EQ(NULL, apis->GetSchema(std::string()));
EXPECT_EQ(NULL, apis->GetSchema("experimental"));
EXPECT_EQ(NULL, apis->GetSchema("experimental"));
EXPECT_EQ(NULL, apis->GetSchema("foo"));
« no previous file with comments | « chrome/common/extensions/api/extension_api.cc ('k') | chrome/common/extensions/csp_validator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698