Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: chrome/browser/prefs/proxy_config_dictionary.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/proxy_config_dictionary.cc
diff --git a/chrome/browser/prefs/proxy_config_dictionary.cc b/chrome/browser/prefs/proxy_config_dictionary.cc
index a99fa7ca2d4bdd09ff98719805d1b866bc879ed3..b6db8229c013c264f1dfa025357c31f611b07a2f 100644
--- a/chrome/browser/prefs/proxy_config_dictionary.cc
+++ b/chrome/browser/prefs/proxy_config_dictionary.cc
@@ -67,12 +67,20 @@ bool ProxyConfigDictionary::HasBypassList() const {
// static
DictionaryValue* ProxyConfigDictionary::CreateDirect() {
- return CreateDictionary(ProxyPrefs::MODE_DIRECT, "", false, "", "");
+ return CreateDictionary(ProxyPrefs::MODE_DIRECT,
+ std::string(),
+ false,
+ std::string(),
+ std::string());
}
// static
DictionaryValue* ProxyConfigDictionary::CreateAutoDetect() {
- return CreateDictionary(ProxyPrefs::MODE_AUTO_DETECT, "", false, "", "");
+ return CreateDictionary(ProxyPrefs::MODE_AUTO_DETECT,
+ std::string(),
+ false,
+ std::string(),
+ std::string());
}
// static
@@ -80,7 +88,10 @@ DictionaryValue* ProxyConfigDictionary::CreatePacScript(
const std::string& pac_url,
bool pac_mandatory) {
return CreateDictionary(ProxyPrefs::MODE_PAC_SCRIPT,
- pac_url, pac_mandatory, "", "");
+ pac_url,
+ pac_mandatory,
+ std::string(),
+ std::string());
}
// static
@@ -88,8 +99,11 @@ DictionaryValue* ProxyConfigDictionary::CreateFixedServers(
const std::string& proxy_server,
const std::string& bypass_list) {
if (!proxy_server.empty()) {
- return CreateDictionary(
- ProxyPrefs::MODE_FIXED_SERVERS, "", false, proxy_server, bypass_list);
+ return CreateDictionary(ProxyPrefs::MODE_FIXED_SERVERS,
+ std::string(),
+ false,
+ proxy_server,
+ bypass_list);
} else {
return CreateDirect();
}
@@ -97,7 +111,11 @@ DictionaryValue* ProxyConfigDictionary::CreateFixedServers(
// static
DictionaryValue* ProxyConfigDictionary::CreateSystem() {
- return CreateDictionary(ProxyPrefs::MODE_SYSTEM, "", false, "", "");
+ return CreateDictionary(ProxyPrefs::MODE_SYSTEM,
+ std::string(),
+ false,
+ std::string(),
+ std::string());
}
// static
« no previous file with comments | « chrome/browser/prefs/command_line_pref_store_unittest.cc ('k') | chrome/browser/prefs/proxy_policy_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698