google_apis/gaia/google_service_auth_error_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gaia/google_service_auth_error_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gaia/google_service_auth_error_unittest.cc

diff --git a/google_apis/gaia/google_service_auth_error_unittest.cc b/google_apis/gaia/google_service_auth_error_unittest.cc

index 59aa5105fc36ead3a99c5eac6bf4cf5a7bd6b669..15155b64e945a15259c9b3ae555d28da79a68e0d 100644

--- a/google_apis/gaia/google_service_auth_error_unittest.cc

+++ b/google_apis/gaia/google_service_auth_error_unittest.cc

@@ -64,7 +64,7 @@ TEST_F(GoogleServiceAuthErrorTest, CaptchaChallenge) {

EXPECT_TRUE(value->GetDictionary("captcha", &captcha_value));

ASSERT_TRUE(captcha_value);

ExpectDictStringValue("captcha_token", *captcha_value, "token");

- ExpectDictStringValue("", *captcha_value, "audioUrl");

+ ExpectDictStringValue(std::string(), *captcha_value, "audioUrl");

ExpectDictStringValue("http://www.google.com/", *captcha_value, "imageUrl");

ExpectDictStringValue("http://www.bing.com/", *captcha_value, "unlockUrl");

ExpectDictIntegerValue(0, *captcha_value, "imageWidth");