Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: content/browser/database_browsertest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/database_browsertest.cc
diff --git a/content/browser/database_browsertest.cc b/content/browser/database_browsertest.cc
index 48f7304176c384b5b4bc7233fa2c597fba150c33..29030ad9eeab9d02f2a5cba6eb2151d7bc996430 100644
--- a/content/browser/database_browsertest.cc
+++ b/content/browser/database_browsertest.cc
@@ -102,7 +102,7 @@ IN_PROC_BROWSER_TEST_F(DatabaseTest, DeleteRecord) {
CreateTable(shell());
InsertRecord(shell(), "text");
DeleteRecord(shell(), 0);
- CompareRecords(shell(), "");
+ CompareRecords(shell(), std::string());
InsertRecord(shell(), "0");
InsertRecord(shell(), "1");
@@ -151,12 +151,12 @@ IN_PROC_BROWSER_TEST_F(DatabaseTest, DatabaseOperations) {
for (int i = 0; i < 10; ++i)
DeleteRecord(shell(), 0);
- CompareRecords(shell(), "");
+ CompareRecords(shell(), std::string());
RunScriptAndCheckResult(
shell(), "deleteRecord(1)", "could not find row with index: 1");
- CompareRecords(shell(), "");
+ CompareRecords(shell(), std::string());
}
// Create records in the database and verify they persist after reload.
@@ -186,7 +186,7 @@ IN_PROC_BROWSER_TEST_F(DatabaseTest, OffTheRecordCannotReadRegularDatabase) {
ASSERT_FALSE(HasTable(otr));
CreateTable(otr);
- CompareRecords(otr, "");
+ CompareRecords(otr, std::string());
}
// Attempt to read a database created in an off the record browser from a
@@ -200,7 +200,7 @@ IN_PROC_BROWSER_TEST_F(DatabaseTest, RegularCannotReadOffTheRecordDatabase) {
Navigate(shell());
ASSERT_FALSE(HasTable(shell()));
CreateTable(shell());
- CompareRecords(shell(), "");
+ CompareRecords(shell(), std::string());
}
// Verify DB changes within first window are present in the second window.

Powered by Google App Engine
This is Rietveld 408576698