Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7560)

Unified Diff: chrome/browser/profiles/profile_downloader_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_downloader_unittest.cc
diff --git a/chrome/browser/profiles/profile_downloader_unittest.cc b/chrome/browser/profiles/profile_downloader_unittest.cc
index 2e47968826603f84a11db0b4556c23df0c4786f4..5346694d077ec1b161c54dd5351e4319d1ada630 100644
--- a/chrome/browser/profiles/profile_downloader_unittest.cc
+++ b/chrome/browser/profiles/profile_downloader_unittest.cc
@@ -68,25 +68,25 @@ TEST_F(ProfileDownloaderTest, ParseData) {
true);
// Data with only name.
- VerifyWithNameAndURL("Pat Smith", "", "", true);
+ VerifyWithNameAndURL("Pat Smith", std::string(), std::string(), true);
// Data with only URL.
VerifyWithNameAndURL(
- "",
+ std::string(),
"https://example.com/--Abc/AAAAAAAAAAI/AAAAAAAAACQ/Efg/photo.jpg",
"https://example.com/--Abc/AAAAAAAAAAI/AAAAAAAAACQ/Efg/s32-c/photo.jpg",
true);
// Data without name or URL.
- VerifyWithNameAndURL("", "", "", false);
+ VerifyWithNameAndURL(std::string(), std::string(), std::string(), false);
// Data with an invalid URL.
- VerifyWithNameAndURL( "", "invalid url", "", false);
+ VerifyWithNameAndURL(std::string(), "invalid url", std::string(), false);
}
TEST_F(ProfileDownloaderTest, DefaultURL) {
// Empty URL should be default photo
- EXPECT_TRUE(ProfileDownloader::IsDefaultProfileImageURL(""));
+ EXPECT_TRUE(ProfileDownloader::IsDefaultProfileImageURL(std::string()));
// Picasa default photo
EXPECT_TRUE(ProfileDownloader::IsDefaultProfileImageURL(
"https://example.com/-4/AAAAAAAAAAA/AAAAAAAAAAE/G/s64-c/photo.jpg"));
« no previous file with comments | « chrome/browser/profiles/gaia_info_update_service_unittest.cc ('k') | chrome/browser/profiles/profile_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698