chrome/browser/printing/print_dialog_cloud_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_dialog_cloud_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/printing/print_dialog_cloud_unittest.cc

diff --git a/chrome/browser/printing/print_dialog_cloud_unittest.cc b/chrome/browser/printing/print_dialog_cloud_unittest.cc

index 217fa532870c1dc04d5c0de4a134785d325d4f25..ce50f287e83748533313dc4f5a31af519dc846ca 100644

--- a/chrome/browser/printing/print_dialog_cloud_unittest.cc

+++ b/chrome/browser/printing/print_dialog_cloud_unittest.cc

@@ -270,7 +270,7 @@ TEST_F(CloudPrintDataSenderTest, NoData) {

TEST_F(CloudPrintDataSenderTest, EmptyData) {

EXPECT_CALL(*mock_helper_, CallJavascriptFunction(_, _, _)).Times(0);

- std::string data("");

+ std::string data;

scoped_refptr<CloudPrintDataSender> print_data_sender(

CreateSender(base::RefCountedString::TakeString(&data)));

base::FilePath test_data_file_name = GetTestDataFileName();