Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: chrome/browser/extensions/webstore_standalone_installer.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/webstore_installer.cc ('k') | chrome/browser/feedback/feedback_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/webstore_standalone_installer.cc
diff --git a/chrome/browser/extensions/webstore_standalone_installer.cc b/chrome/browser/extensions/webstore_standalone_installer.cc
index cadce504263ae667f0b4334e82eaf5b3c70e54b3..7df550f80bab3e75bd2722d889f9e61debba871e 100644
--- a/chrome/browser/extensions/webstore_standalone_installer.cc
+++ b/chrome/browser/extensions/webstore_standalone_installer.cc
@@ -80,7 +80,7 @@ void WebstoreStandaloneInstaller::OnWebstoreRequestFailure() {
void WebstoreStandaloneInstaller::OnWebstoreResponseParseSuccess(
DictionaryValue* webstore_data) {
if (!CheckRequestorAlive()) {
- CompleteInstall("");
+ CompleteInstall(std::string());
return;
}
@@ -141,13 +141,13 @@ void WebstoreStandaloneInstaller::OnWebstoreResponseParseSuccess(
// Assume ownership of webstore_data.
webstore_data_.reset(webstore_data);
- scoped_refptr<WebstoreInstallHelper> helper = new WebstoreInstallHelper(
- this,
- id_,
- manifest,
- "", // We don't have any icon data.
- icon_url,
- profile_->GetRequestContext());
+ scoped_refptr<WebstoreInstallHelper> helper =
+ new WebstoreInstallHelper(this,
+ id_,
+ manifest,
+ std::string(), // We don't have any icon data.
+ icon_url,
+ profile_->GetRequestContext());
// The helper will call us back via OnWebstoreParseSucces or
// OnWebstoreParseFailure.
helper->Start();
@@ -165,7 +165,7 @@ void WebstoreStandaloneInstaller::OnWebstoreParseSuccess(
CHECK_EQ(id_, id);
if (!CheckRequestorAlive()) {
- CompleteInstall("");
+ CompleteInstall(std::string());
return;
}
@@ -190,7 +190,7 @@ void WebstoreStandaloneInstaller::OnWebstoreParseFailure(
void WebstoreStandaloneInstaller::InstallUIProceed() {
if (!CheckRequestorAlive()) {
- CompleteInstall("");
+ CompleteInstall(std::string());
return;
}
@@ -219,7 +219,7 @@ void WebstoreStandaloneInstaller::InstallUIAbort(bool user_initiated) {
void WebstoreStandaloneInstaller::OnExtensionInstallSuccess(
const std::string& id) {
CHECK_EQ(id_, id);
- CompleteInstall("");
+ CompleteInstall(std::string());
}
void WebstoreStandaloneInstaller::OnExtensionInstallFailure(
« no previous file with comments | « chrome/browser/extensions/webstore_installer.cc ('k') | chrome/browser/feedback/feedback_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698