chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Unified Diff: chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/devtools_http_client_unittest.cc ('k') | chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc

diff --git a/chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc b/chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc

index fcc3dce9de705a5a8124b3ffaf45450c5f7b7c24..1333090f80990be523f97d5559b640fa372bcf37 100644

--- a/chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc

+++ b/chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc

@@ -19,7 +19,7 @@ TEST(JavaScriptDialogManager, NoDialog) {

ASSERT_EQ(kNoAlertOpen, manager.GetDialogMessage(&message).code());

ASSERT_FALSE(manager.IsDialogOpen());

ASSERT_STREQ("HI", message.c_str());

- ASSERT_EQ(kNoAlertOpen, manager.HandleDialog(false, "").code());

+ ASSERT_EQ(kNoAlertOpen, manager.HandleDialog(false, std::string()).code());

}

namespace {

@@ -73,7 +73,7 @@ TEST(JavaScriptDialogManager, ReconnectClearsStateAndSendsEnable) {

ASSERT_EQ("Page.enable", client.method_);

ASSERT_FALSE(manager.IsDialogOpen());

ASSERT_EQ(kNoAlertOpen, manager.GetDialogMessage(&message).code());

- ASSERT_EQ(kNoAlertOpen, manager.HandleDialog(false, "").code());

+ ASSERT_EQ(kNoAlertOpen, manager.HandleDialog(false, std::string()).code());

}

namespace {

@@ -125,10 +125,10 @@ TEST(JavaScriptDialogManager, OneDialog) {

ASSERT_EQ("hi", message);

client.set_closing_count(1);

- ASSERT_EQ(kOk, manager.HandleDialog(false, "").code());

+ ASSERT_EQ(kOk, manager.HandleDialog(false, std::string()).code());

ASSERT_FALSE(manager.IsDialogOpen());

ASSERT_EQ(kNoAlertOpen, manager.GetDialogMessage(&message).code());

- ASSERT_EQ(kNoAlertOpen, manager.HandleDialog(false, "").code());

+ ASSERT_EQ(kNoAlertOpen, manager.HandleDialog(false, std::string()).code());

}

TEST(JavaScriptDialogManager, TwoDialogs) {

@@ -145,16 +145,16 @@ TEST(JavaScriptDialogManager, TwoDialogs) {

ASSERT_TRUE(manager.IsDialogOpen());

ASSERT_EQ("1", message);

- ASSERT_EQ(kOk, manager.HandleDialog(false, "").code());

+ ASSERT_EQ(kOk, manager.HandleDialog(false, std::string()).code());

ASSERT_TRUE(manager.IsDialogOpen());

ASSERT_EQ(kOk, manager.GetDialogMessage(&message).code());

ASSERT_EQ("2", message);

client.set_closing_count(2);

- ASSERT_EQ(kOk, manager.HandleDialog(false, "").code());

+ ASSERT_EQ(kOk, manager.HandleDialog(false, std::string()).code());

ASSERT_FALSE(manager.IsDialogOpen());

ASSERT_EQ(kNoAlertOpen, manager.GetDialogMessage(&message).code());

- ASSERT_EQ(kNoAlertOpen, manager.HandleDialog(false, "").code());

+ ASSERT_EQ(kNoAlertOpen, manager.HandleDialog(false, std::string()).code());

}

TEST(JavaScriptDialogManager, OneDialogManualClose) {

@@ -174,5 +174,5 @@ TEST(JavaScriptDialogManager, OneDialogManualClose) {

manager.OnEvent("Page.javascriptDialogClosing", params);

ASSERT_FALSE(manager.IsDialogOpen());

ASSERT_EQ(kNoAlertOpen, manager.GetDialogMessage(&message).code());

- ASSERT_EQ(kNoAlertOpen, manager.HandleDialog(false, "").code());

+ ASSERT_EQ(kNoAlertOpen, manager.HandleDialog(false, std::string()).code());

}