chrome/renderer/extensions/extension_helper.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/extension_helper.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/extension_helper.cc

diff --git a/chrome/renderer/extensions/extension_helper.cc b/chrome/renderer/extensions/extension_helper.cc

index a488cb7902c1d05d0a4ebbcac8f322db14cc14c9..ac456a84395273e9c1590fefebba6258fc791b7c 100644

--- a/chrome/renderer/extensions/extension_helper.cc

+++ b/chrome/renderer/extensions/extension_helper.cc

@@ -313,8 +313,12 @@ void ExtensionHelper::OnExecuteCode(

WebFrame* main_frame = webview->mainFrame();

if (!main_frame) {

ListValue val;

- Send(new ExtensionHostMsg_ExecuteCodeFinished(

- routing_id(), params.request_id, "No main frame", -1, GURL(""), val));

+ Send(new ExtensionHostMsg_ExecuteCodeFinished(routing_id(),

+ params.request_id,

+ "No main frame",

+ -1,

+ GURL(std::string()),

+ val));

return;

}