chrome/browser/extensions/extension_prefs.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_prefs.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_prefs.cc

diff --git a/chrome/browser/extensions/extension_prefs.cc b/chrome/browser/extensions/extension_prefs.cc

index 0f1d7439e067f7f646fecc3591523c1644dd483d..b24e0e7d22b2761587a6639eda5e1546463436c8 100644

--- a/chrome/browser/extensions/extension_prefs.cc

+++ b/chrome/browser/extensions/extension_prefs.cc

@@ -1670,7 +1670,8 @@ void ExtensionPrefs::SetDelayedInstallInfo(

if (extension->RequiresSortOrdinal()) {

extension_dict->SetString(

kPrefSuggestedPageOrdinal,

- page_ordinal.IsValid() ? page_ordinal.ToInternalValue() : "");

+ page_ordinal.IsValid() ? page_ordinal.ToInternalValue()

+ : std::string());

}

UpdateExtensionPref(extension->id(), kDelayedInstallInfo, extension_dict);