chrome/browser/extensions/api/webstore_private/webstore_private_api.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_socket_proxy_private/web_socket_proxy_private_api.cc ('k') | chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

index 0264c36c7b186849a20e59027dcc3f3298ae471d..8cb59aa2f9236fd802fc8fe2900387d638829f91 100644

--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

@@ -295,7 +295,7 @@ bool BeginInstallWithManifestFunction::RunImpl() {

void BeginInstallWithManifestFunction::SetResultCode(ResultCode code) {

switch (code) {

case ERROR_NONE:

- SetResult(Value::CreateStringValue(""));

+ SetResult(Value::CreateStringValue(std::string()));

break;

case UNKNOWN_ERROR:

SetResult(Value::CreateStringValue("unknown_error"));

@@ -338,7 +338,7 @@ void BeginInstallWithManifestFunction::OnWebstoreParseSuccess(

Extension::FROM_WEBSTORE,

id,

localized_name_,

- "",

+ std::string(),

&error);

if (!dummy_extension_) {