base/file_util_posix.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/file_util_posix.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/file_util_posix.cc

diff --git a/base/file_util_posix.cc b/base/file_util_posix.cc

index fa2c1ffe35456485225b0449459334565e14dc7a..8bf164ace5c4a175907d416672e0507362808e6c 100644

--- a/base/file_util_posix.cc

+++ b/base/file_util_posix.cc

@@ -541,7 +541,8 @@ bool CreateDirectory(const FilePath& full_path) {

base::FilePath MakeUniqueDirectory(const base::FilePath& path) {

const int kMaxAttempts = 20;

for (int attempts = 0; attempts < kMaxAttempts; attempts++) {

- int uniquifier = GetUniquePathNumber(path, FILE_PATH_LITERAL(""));

+ int uniquifier =

+ GetUniquePathNumber(path, base::FilePath::StringType());

if (uniquifier < 0)

break;

base::FilePath test_path = (uniquifier == 0) ? path :

« no previous file with comments | « base/debug/trace_event_unittest.cc ('k') | base/file_util_unittest.cc » ('j') | no next file with comments »