Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3589)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
index 3d0f2d9482056ff5ee7959d04da199e6fe14c771..032d5eceab5296580fbec821803a52e81f08e190 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
@@ -1004,8 +1004,8 @@ void SafeBrowsingBlockingPageV2::PopulateMalwareStringDictionary(
if (!CanShowMalwareDetailsOption()) {
strings->SetBoolean(kDisplayCheckBox, false);
- strings->SetString("confirm_text", "");
- strings->SetString(kBoxChecked, "");
+ strings->SetString("confirm_text", std::string());
+ strings->SetString(kBoxChecked, std::string());
} else {
// Show the checkbox for sending malware details.
strings->SetBoolean(kDisplayCheckBox, true);
@@ -1022,7 +1022,7 @@ void SafeBrowsingBlockingPageV2::PopulateMalwareStringDictionary(
if (IsPrefEnabled(prefs::kSafeBrowsingReportingEnabled))
strings->SetString(kBoxChecked, "yes");
else
- strings->SetString(kBoxChecked, "");
+ strings->SetString(kBoxChecked, std::string());
}
strings->SetString("report_error", string16());
@@ -1042,10 +1042,11 @@ void SafeBrowsingBlockingPageV2::PopulatePhishingStringDictionary(
string16(),
l10n_util::GetStringUTF16(IDS_SAFE_BROWSING_PHISHING_V2_DESCRIPTION2));
- strings->SetString("details", "");
- strings->SetString("confirm_text", "");
- strings->SetString(kBoxChecked, "");
- strings->SetString("report_error",
+ strings->SetString("details", std::string());
+ strings->SetString("confirm_text", std::string());
+ strings->SetString(kBoxChecked, std::string());
+ strings->SetString(
+ "report_error",
l10n_util::GetStringUTF16(IDS_SAFE_BROWSING_PHISHING_V2_REPORT_ERROR));
strings->SetBoolean(kDisplayCheckBox, false);
strings->SetString("learnMore",
« no previous file with comments | « chrome/browser/safe_browsing/protocol_manager_unittest.cc ('k') | chrome/browser/safe_browsing/safe_browsing_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698