chrome/browser/net/dns_probe_job_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/dns_probe_job_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/net/dns_probe_job_unittest.cc

diff --git a/chrome/browser/net/dns_probe_job_unittest.cc b/chrome/browser/net/dns_probe_job_unittest.cc

index 06d6965527ca725967fe1fad8247e7540145a319..1fe8766a6d7ea440e6ea096040695e78957087e2 100644

--- a/chrome/browser/net/dns_probe_job_unittest.cc

+++ b/chrome/browser/net/dns_probe_job_unittest.cc

@@ -54,7 +54,7 @@ void DnsProbeJobTest::RunProbe(MockDnsClientRule::Result good_result,

const uint16 kTypeA = net::dns_protocol::kTypeA;

MockDnsClientRuleList rules;

rules.push_back(MockDnsClientRule("google.com", kTypeA, good_result));

- rules.push_back(MockDnsClientRule("", kTypeA, bad_result));

+ rules.push_back(MockDnsClientRule(std::string(), kTypeA, bad_result));

scoped_ptr<DnsClient> dns_client = CreateMockDnsClient(config, rules);

dns_client->SetConfig(config);