chrome/browser/media_galleries/media_galleries_dialog_controller.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/media_galleries_dialog_controller.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/media_stream_devices_controller.cc ('k') | chrome/browser/media_galleries/media_galleries_preferences.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/media_galleries_dialog_controller.cc

diff --git a/chrome/browser/media_galleries/media_galleries_dialog_controller.cc b/chrome/browser/media_galleries/media_galleries_dialog_controller.cc

index 98ba8daaec6415f1f95b40fba73e5a79c3cce9f1..bcd3ae3fd30f867412aafa23f08bb05118124eca 100644

--- a/chrome/browser/media_galleries/media_galleries_dialog_controller.cc

+++ b/chrome/browser/media_galleries/media_galleries_dialog_controller.cc

@@ -147,7 +147,7 @@ string16 MediaGalleriesDialogController::GetHeader() const {

}

string16 MediaGalleriesDialogController::GetSubtext() const {

- std::string extension_name(extension_ ? extension_->name() : "");

+ std::string extension_name(extension_ ? extension_->name() : std::string());

return l10n_util::GetStringFUTF16(IDS_MEDIA_GALLERIES_DIALOG_SUBTEXT,

UTF8ToUTF16(extension_name));

}

@@ -184,7 +184,9 @@ void MediaGalleriesDialogController::OnAddFolderClicked() {

ui::SelectFileDialog::SELECT_FOLDER,

l10n_util::GetStringUTF16(IDS_MEDIA_GALLERIES_DIALOG_ADD_GALLERY_TITLE),

user_data_dir,

- NULL, 0, FILE_PATH_LITERAL(""),

+ NULL,

+ 0,

+ base::FilePath::StringType(),

web_contents_->GetView()->GetTopLevelNativeWindow(),

NULL);

}