chrome/browser/content_settings/content_settings_provider_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/content_settings_provider_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/content_settings_provider.h ('k') | chrome/browser/content_settings/content_settings_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/content_settings_provider_unittest.cc

diff --git a/chrome/browser/content_settings/content_settings_provider_unittest.cc b/chrome/browser/content_settings/content_settings_provider_unittest.cc

index e0857b3292a9ffa36983b3d45f4cf14fe4d5eab0..0832a1ce90c8f3aa067b7ea8e74514ef3fc706b9 100644

--- a/chrome/browser/content_settings/content_settings_provider_unittest.cc

+++ b/chrome/browser/content_settings/content_settings_provider_unittest.cc

@@ -46,11 +46,18 @@ TEST(ContentSettingsProviderTest, Mock) {

CONTENT_SETTINGS_TYPE_PLUGINS,

"flash_plugin", false));

EXPECT_EQ(CONTENT_SETTING_DEFAULT,

- GetContentSetting(&mock_provider, url, url,

- CONTENT_SETTINGS_TYPE_GEOLOCATION, "", false));

+ GetContentSetting(&mock_provider,

+ url,

+ CONTENT_SETTINGS_TYPE_GEOLOCATION,

+ std::string(),

+ false));

EXPECT_EQ(NULL,

- GetContentSettingValue(&mock_provider, url, url,

- CONTENT_SETTINGS_TYPE_GEOLOCATION, "",

+ GetContentSettingValue(&mock_provider,

+ url,

+ CONTENT_SETTINGS_TYPE_GEOLOCATION,

+ std::string(),

false));

bool owned = mock_provider.SetWebsiteSetting(