chrome/renderer/automation/automation_renderer_helper_browsertest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/automation/automation_renderer_helper_browsertest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/password_autofill_agent_browsertest.cc ('k') | chrome/renderer/chrome_content_renderer_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/automation/automation_renderer_helper_browsertest.cc

diff --git a/chrome/renderer/automation/automation_renderer_helper_browsertest.cc b/chrome/renderer/automation/automation_renderer_helper_browsertest.cc

index 659d312ded51b232b39ac9d08e948b214e92620f..65bd0188d09805357df07ccc58c67f5b4a64d017 100644

--- a/chrome/renderer/automation/automation_renderer_helper_browsertest.cc

+++ b/chrome/renderer/automation/automation_renderer_helper_browsertest.cc

@@ -84,9 +84,9 @@ TEST_F(AutomationRendererHelperTest, RTLSnapshot) {

}

TEST_F(AutomationRendererHelperTest, ScriptChain) {

- ScriptEvaluationRequest request("({'result': 10})", "");

- ScriptEvaluationRequest request_plus1(

- "({'result': arguments[0].result + 1})", "");

+ ScriptEvaluationRequest request("({'result': 10})", std::string());

+ ScriptEvaluationRequest request_plus1("({'result': arguments[0].result + 1})",

+ std::string());

std::vector<ScriptEvaluationRequest> script_chain;

script_chain.push_back(request);

script_chain.push_back(request_plus1);

@@ -102,10 +102,10 @@ TEST_F(AutomationRendererHelperTest, ScriptChain) {

}

TEST_F(AutomationRendererHelperTest, ScriptChainError) {

- ScriptEvaluationRequest request("({'result': 10})", "");

+ ScriptEvaluationRequest request("({'result': 10})", std::string());

ScriptEvaluationRequest error_request(

"({'result': arguments[0].result + 1, 'error': {'msg': 'some msg'}})",

- "");

+ std::string());

std::vector<ScriptEvaluationRequest> script_chain;

script_chain.push_back(request);

script_chain.push_back(error_request);