chrome/browser/ui/certificate_dialogs.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/certificate_dialogs.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/certificate_dialogs.cc

diff --git a/chrome/browser/ui/certificate_dialogs.cc b/chrome/browser/ui/certificate_dialogs.cc

index 8e69b5d59d27ca41b68a4dd4740e6da7fa0f7bcd..939c3a13a7ee7b0f60c947dfb8cbc602f3208d0d 100644

--- a/chrome/browser/ui/certificate_dialogs.cc

+++ b/chrome/browser/ui/certificate_dialogs.cc

@@ -52,7 +52,7 @@ std::string GetBase64String(net::X509Certificate::OSCertHandle cert) {

if (!base::Base64Encode(

x509_certificate_model::GetDerString(cert), &base64)) {

LOG(ERROR) << "base64 encoding error";

- return "";

+ return std::string();

}

return "-----BEGIN CERTIFICATE-----\r\n" +

WrapAt64(base64) +

« no previous file with comments | « chrome/browser/ui/browser_tabrestore.cc ('k') | chrome/browser/ui/chrome_pages.cc » ('j') | no next file with comments »