chrome/browser/printing/cloud_print/cloud_print_setup_source.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/cloud_print/cloud_print_setup_source.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/printing/cloud_print/cloud_print_setup_source.cc

diff --git a/chrome/browser/printing/cloud_print/cloud_print_setup_source.cc b/chrome/browser/printing/cloud_print/cloud_print_setup_source.cc

index 7bb6d73794a4ab8362a890f082d2f28b27cae87d..8c18da80b961a7276d3194f06e21718c7850cf6a 100644

--- a/chrome/browser/printing/cloud_print/cloud_print_setup_source.cc

+++ b/chrome/browser/printing/cloud_print/cloud_print_setup_source.cc

@@ -87,7 +87,7 @@ void CloudPrintSetupSource::StartDataRequest(

// None of the strings used here currently have sync-specific wording in

// them. There is a unit test to catch if that happens.

- dict->SetString("introduction", "");

+ dict->SetString("introduction", std::string());

AddString(dict, "signinprefix", IDS_SYNC_LOGIN_SIGNIN_PREFIX);

AddString(dict, "signinsuffix", IDS_SYNC_LOGIN_SIGNIN_SUFFIX);

AddString(dict, "cannotbeblank", IDS_SYNC_CANNOT_BE_BLANK);