chrome/browser/extensions/api/proxy/proxy_api.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/proxy/proxy_api.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/proxy/proxy_api.cc

diff --git a/chrome/browser/extensions/api/proxy/proxy_api.cc b/chrome/browser/extensions/api/proxy/proxy_api.cc

index ff945d3afd06a99b2fb1132f1ad341b7af528e2c..5e811bd53b362c81e78931f6a115054d03b071c7 100644

--- a/chrome/browser/extensions/api/proxy/proxy_api.cc

+++ b/chrome/browser/extensions/api/proxy/proxy_api.cc

@@ -41,7 +41,7 @@ void ProxyEventRouter::OnProxyError(

DictionaryValue* dict = new DictionaryValue();

dict->SetBoolean(keys::kProxyEventFatal, true);

dict->SetString(keys::kProxyEventError, net::ErrorToString(error_code));

- dict->SetString(keys::kProxyEventDetails, "");

+ dict->SetString(keys::kProxyEventDetails, std::string());

args->Append(dict);

if (profile) {