chrome/browser/extensions/api/extension_action/script_badge_apitest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/script_badge_apitest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/extension_action/page_action_apitest.cc ('k') | chrome/browser/extensions/api/file_system/file_system_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/script_badge_apitest.cc

diff --git a/chrome/browser/extensions/api/extension_action/script_badge_apitest.cc b/chrome/browser/extensions/api/extension_action/script_badge_apitest.cc

index fd32e96d1088ca67b3262ad7188c10efce13733a..ff7fae79e8ba0d4661fa97e9132e2db706cfc0d1 100644

--- a/chrome/browser/extensions/api/extension_action/script_badge_apitest.cc

+++ b/chrome/browser/extensions/api/extension_action/script_badge_apitest.cc

@@ -88,7 +88,8 @@ IN_PROC_BROWSER_TEST_F(ScriptBadgeApiTest, Basics) {

ResultCatcher catcher;

// Visit a non-extension page so the extension can run a content script and

// cause the script badge to be animated in.

- ui_test_utils::NavigateToURL(browser(), test_server()->GetURL(""));

+ ui_test_utils::NavigateToURL(browser(),

+ test_server()->GetURL(std::string()));

ASSERT_TRUE(catcher.GetNextResult());

}

EXPECT_TRUE(script_badge->GetIsVisible(tab_id));