Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5931)

Unified Diff: chrome/common/extensions/manifest_url_handler.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_url_handler.cc
diff --git a/chrome/common/extensions/manifest_url_handler.cc b/chrome/common/extensions/manifest_url_handler.cc
index 2e18eb13cf146b407bf8e53e45b28f2ff8bcabfd..690cc03e21a78851a1062d0c9f856a2432708e61 100644
--- a/chrome/common/extensions/manifest_url_handler.cc
+++ b/chrome/common/extensions/manifest_url_handler.cc
@@ -125,8 +125,8 @@ bool HomepageURLHandler::Parse(Extension* extension, string16* error) {
std::string homepage_url_str;
if (!extension->manifest()->GetString(keys::kHomepageURL,
&homepage_url_str)) {
- *error = ErrorUtils::FormatErrorMessageUTF16(
- errors::kInvalidHomepageURL, "");
+ *error = ErrorUtils::FormatErrorMessageUTF16(errors::kInvalidHomepageURL,
+ std::string());
return false;
}
manifest_url->url_ = GURL(homepage_url_str);
@@ -156,8 +156,8 @@ bool UpdateURLHandler::Parse(Extension* extension, string16* error) {
std::string tmp_update_url;
if (!extension->manifest()->GetString(keys::kUpdateURL, &tmp_update_url)) {
- *error = ErrorUtils::FormatErrorMessageUTF16(
- errors::kInvalidUpdateURL, "");
+ *error = ErrorUtils::FormatErrorMessageUTF16(errors::kInvalidUpdateURL,
+ std::string());
return false;
}

Powered by Google App Engine
This is Rietveld 408576698