Rewrite std::string("") to std::string(), Linux edition.

sync/notifier/p2p_invalidator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/notifier/p2p_invalidator.h"
 
 #include <algorithm>
 
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
@@ skipping 22 matching lines @@
 std::string P2PNotificationTargetToString(P2PNotificationTarget target) {
   switch (target) {
     case NOTIFY_SELF:
       return kNotifySelf;
     case NOTIFY_OTHERS:
       return kNotifyOthers;
     case NOTIFY_ALL:
       return kNotifyAll;
     default:
       NOTREACHED();
-      return "";
+      return std::string();
   }
 }
 
 P2PNotificationTarget P2PNotificationTargetFromString(
     const std::string& target_str) {
   if (target_str == kNotifySelf) {
     return NOTIFY_SELF;
   }
   if (target_str == kNotifyOthers) {
     return NOTIFY_OTHERS;
@@ skipping 110 matching lines @@
   // TODO(akalin): Handle arbitrary object IDs (http://crbug.com/140411).
   DCHECK(thread_checker_.CalledOnValidThread());
   ObjectIdSet new_ids;
   const ObjectIdSet& old_ids = registrar_.GetRegisteredIds(handler);
   std::set_difference(ids.begin(), ids.end(),
                       old_ids.begin(), old_ids.end(),
                       std::inserter(new_ids, new_ids.end()),
                       ObjectIdLessThan());
   registrar_.UpdateRegisteredIds(handler, ids);
   const P2PNotificationData notification_data(
-      invalidator_client_id_, NOTIFY_SELF,
-      ObjectIdSetToInvalidationMap(new_ids, ""));
+      invalidator_client_id_,
+      NOTIFY_SELF,
+      ObjectIdSetToInvalidationMap(new_ids, std::string()));
   SendNotificationData(notification_data);
 }
 
 void P2PInvalidator::UnregisterHandler(InvalidationHandler* handler) {
   DCHECK(thread_checker_.CalledOnValidThread());
   registrar_.UnregisterHandler(handler);
 }
 
 void P2PInvalidator::Acknowledge(const invalidation::ObjectId& id,
                                  const AckHandle& ack_handle) {
@@ skipping 31 matching lines @@
   SendNotificationData(notification_data);
 }
 
 void P2PInvalidator::OnNotificationsEnabled() {
   DCHECK(thread_checker_.CalledOnValidThread());
   bool just_turned_on = (notifications_enabled_ == false);
   notifications_enabled_ = true;
   registrar_.UpdateInvalidatorState(INVALIDATIONS_ENABLED);
   if (just_turned_on) {
     const P2PNotificationData notification_data(
-        invalidator_client_id_, NOTIFY_SELF,
-        ObjectIdSetToInvalidationMap(registrar_.GetAllRegisteredIds(), ""));
+        invalidator_client_id_,
+        NOTIFY_SELF,
+        ObjectIdSetToInvalidationMap(registrar_.GetAllRegisteredIds(),
+                                     std::string()));
     SendNotificationData(notification_data);
   }
 }
 
 void P2PInvalidator::OnNotificationsDisabled(
     notifier::NotificationsDisabledReason reason) {
   DCHECK(thread_checker_.CalledOnValidThread());
   registrar_.UpdateInvalidatorState(FromNotifierReason(reason));
 }
 
@@ skipping 10 matching lines @@
     return;
   }
   if (notification.channel != kSyncP2PNotificationChannel) {
     LOG(WARNING) << "Notification from unexpected source "
                  << notification.channel;
   }
   P2PNotificationData notification_data;
   if (!notification_data.ResetFromString(notification.data)) {
     LOG(WARNING) << "Could not parse notification data from "
                  << notification.data;
-    notification_data =
-        P2PNotificationData(
-            invalidator_client_id_, NOTIFY_ALL,
-            ObjectIdSetToInvalidationMap(registrar_.GetAllRegisteredIds(), ""));
+    notification_data = P2PNotificationData(
+        invalidator_client_id_,
+        NOTIFY_ALL,
+        ObjectIdSetToInvalidationMap(registrar_.GetAllRegisteredIds(),
+                                     std::string()));
   }
   if (!notification_data.IsTargeted(invalidator_client_id_)) {
     DVLOG(1) << "Not a target of the notification -- "
              << "not emitting notification";
     return;
   }
   registrar_.DispatchInvalidationsToHandlers(
       notification_data.GetIdInvalidationMap());
 }
 
@@ skipping 12 matching lines @@
     return;
   }
   notifier::Notification notification;
   notification.channel = kSyncP2PNotificationChannel;
   notification.data = notification_data.ToString();
   DVLOG(1) << "Sending XMPP notification: " << notification.ToString();
   push_client_->SendNotification(notification);
 }
 
 }  // namespace syncer