Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Side by Side Diff: sync/internal_api/syncapi_server_connection_manager_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sync/internal_api/sync_manager_impl_unittest.cc ('k') | sync/notifier/p2p_invalidator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/internal_api/syncapi_server_connection_manager.h" 5 #include "sync/internal_api/syncapi_server_connection_manager.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/synchronization/waitable_event.h" 10 #include "base/synchronization/waitable_event.h"
(...skipping 27 matching lines...) Expand all
38 return false; 38 return false;
39 } 39 }
40 virtual int GetResponseContentLength() const OVERRIDE { 40 virtual int GetResponseContentLength() const OVERRIDE {
41 return 0; 41 return 0;
42 } 42 }
43 virtual const char* GetResponseContent() const OVERRIDE { 43 virtual const char* GetResponseContent() const OVERRIDE {
44 return ""; 44 return "";
45 } 45 }
46 virtual const std::string GetResponseHeaderValue( 46 virtual const std::string GetResponseHeaderValue(
47 const std::string& name) const OVERRIDE { 47 const std::string& name) const OVERRIDE {
48 return ""; 48 return std::string();
49 } 49 }
50 virtual void Abort() OVERRIDE { 50 virtual void Abort() OVERRIDE {
51 wait_for_abort_.Signal(); 51 wait_for_abort_.Signal();
52 } 52 }
53 private: 53 private:
54 base::WaitableEvent wait_for_abort_; 54 base::WaitableEvent wait_for_abort_;
55 }; 55 };
56 56
57 class BlockingHttpPostFactory : public HttpPostProviderFactory { 57 class BlockingHttpPostFactory : public HttpPostProviderFactory {
58 public: 58 public:
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 bool result = server.PostBufferToPath( 101 bool result = server.PostBufferToPath(
102 &params, "/testpath", "testauth", &watcher); 102 &params, "/testpath", "testauth", &watcher);
103 103
104 EXPECT_FALSE(result); 104 EXPECT_FALSE(result);
105 EXPECT_EQ(HttpResponse::CONNECTION_UNAVAILABLE, 105 EXPECT_EQ(HttpResponse::CONNECTION_UNAVAILABLE,
106 params.response.server_status); 106 params.response.server_status);
107 abort_thread.Stop(); 107 abort_thread.Stop();
108 } 108 }
109 109
110 } // namespace syncer 110 } // namespace syncer
OLDNEW
« no previous file with comments | « sync/internal_api/sync_manager_impl_unittest.cc ('k') | sync/notifier/p2p_invalidator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698