Rewrite std::string("") to std::string(), Linux edition.

sync/internal_api/sync_manager_impl_unittest.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Unit tests for the SyncApi. Note that a lot of the underlying
 // functionality is provided by the Syncable layer, which has its own
 // unit tests. We'll test SyncApi specific things in this harness.
 
 #include <cstddef>
 #include <map>
@@ skipping 705 matching lines @@
     return false;
   }
   virtual int GetResponseContentLength() const OVERRIDE {
     return 0;
   }
   virtual const char* GetResponseContent() const OVERRIDE {
     return "";
   }
   virtual const std::string GetResponseHeaderValue(
       const std::string& name) const OVERRIDE {
-    return "";
+    return std::string();
   }
   virtual void Abort() OVERRIDE {}
 };
 
 class TestHttpPostProviderFactory : public HttpPostProviderFactory {
  public:
   virtual ~TestHttpPostProviderFactory() {}
   virtual HttpPostProviderInterface* Create() OVERRIDE {
     return new TestHttpPostProviderInterface();
   }
@@ skipping 76 matching lines @@
     EXPECT_CALL(manager_observer_, OnInitializationComplete(_, _, _, _)).
         WillOnce(SaveArg<0>(&js_backend_));
 
     EXPECT_FALSE(js_backend_.IsInitialized());
 
     std::vector<ModelSafeWorker*> workers;
     ModelSafeRoutingInfo routing_info;
     GetModelSafeRoutingInfo(&routing_info);
 
     // Takes ownership of |fake_invalidator_|.
-    sync_manager_.Init(temp_dir_.path(),
-                       WeakHandle<JsEventHandler>(),
-                       "bogus", 0, false,
-                       scoped_ptr<HttpPostProviderFactory>(
-                           new TestHttpPostProviderFactory()),
-                       workers, &extensions_activity_monitor_, this,
-                       credentials,
-                       scoped_ptr<Invalidator>(fake_invalidator_),
-                       "fake_invalidator_client_id",
-                       "", "",  // bootstrap tokens
-                       scoped_ptr<InternalComponentsFactory>(GetFactory()),
-                       &encryptor_,
-                       &handler_,
-                       NULL);
+    sync_manager_.Init(
+        temp_dir_.path(),
+        WeakHandle<JsEventHandler>(),
+        "bogus",
+        0,
+        false,
+        scoped_ptr<HttpPostProviderFactory>(new TestHttpPostProviderFactory()),
+        workers,
+        &extensions_activity_monitor_,
+        this,
+        credentials,
+        scoped_ptr<Invalidator>(fake_invalidator_),
+        "fake_invalidator_client_id",
+        std::string(),
+        std::string(),  // bootstrap tokens
+        scoped_ptr<InternalComponentsFactory>(GetFactory()),
+        &encryptor_,
+        &handler_,
+        NULL);
 
     sync_manager_.GetEncryptionHandler()->AddObserver(&encryption_observer_);
 
     EXPECT_TRUE(js_backend_.IsInitialized());
 
     for (ModelSafeRoutingInfo::iterator i = routing_info.begin();
          i != routing_info.end(); ++i) {
       type_roots_[i->first] = MakeServerNodeForType(
           sync_manager_.GetUserShare(), i->first);
     }
@@ skipping 327 matching lines @@
       base::ListValue args;
       args.Append(new base::ListValue());
       SendJsMessage(message_name,
                     JsArgList(&args), reply_handler.AsWeakHandle());
     }
 
     {
       base::ListValue args;
       base::ListValue* ids = new base::ListValue();
       args.Append(ids);
-      ids->Append(new base::StringValue(""));
-      SendJsMessage(message_name,
-                    JsArgList(&args), reply_handler.AsWeakHandle());
+      ids->Append(new base::StringValue(std::string()));
+      SendJsMessage(
+          message_name, JsArgList(&args), reply_handler.AsWeakHandle());
     }
 
     {
       base::ListValue args;
       base::ListValue* ids = new base::ListValue();
       args.Append(ids);
       ids->Append(new base::StringValue("nonsense"));
       SendJsMessage(message_name,
                     JsArgList(&args), reply_handler.AsWeakHandle());
     }
@@ skipping 69 matching lines @@
       .Times(5);
 
   {
     base::ListValue args;
     SendJsMessage("getChildNodeIds",
                    JsArgList(&args), reply_handler.AsWeakHandle());
   }
 
   {
     base::ListValue args;
-    args.Append(new base::StringValue(""));
-    SendJsMessage("getChildNodeIds",
-                  JsArgList(&args), reply_handler.AsWeakHandle());
+    args.Append(new base::StringValue(std::string()));
+    SendJsMessage(
+        "getChildNodeIds", JsArgList(&args), reply_handler.AsWeakHandle());
   }
 
   {
     base::ListValue args;
     args.Append(new base::StringValue("nonsense"));
     SendJsMessage("getChildNodeIds",
                   JsArgList(&args), reply_handler.AsWeakHandle());
   }
 
   {
@@ skipping 2074 matching lines @@
   size_t folder_b_pos =
       FindChangeInList(folder_b_id, ChangeRecord::ACTION_DELETE);
   size_t child_pos = FindChangeInList(child_id, ChangeRecord::ACTION_DELETE);
 
   // Deletes should appear before updates.
   EXPECT_LT(child_pos, folder_a_pos);
   EXPECT_LT(folder_b_pos, folder_a_pos);
 }
 
 }  // namespace