Rewrite std::string("") to std::string(), Linux edition.

net/url_request/url_fetcher_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_fetcher_impl.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/file_util.h"
@@ skipping 423 matching lines @@
   virtual TestURLRequestContext* GetURLRequestContext() OVERRIDE {
     if (!context_.get()) {
       context_.reset(new CancelTestURLRequestContext());
       DCHECK(context_->throttler_manager());
 
       // Registers an entry for test url. The backoff time is calculated by:
       //     new_backoff = 2.0 * old_backoff + 0
       // The initial backoff is 2 seconds and maximum backoff is 4 seconds.
       // Maximum retries allowed is set to 2.
       scoped_refptr<URLRequestThrottlerEntry> entry(
-          new URLRequestThrottlerEntry(
-              context_->throttler_manager(),
-              "", 200, 3, 2000, 2.0, 0.0, 4000));
-      context_->throttler_manager()->OverrideEntryForTests(
-          throttle_for_url_, entry);
+          new URLRequestThrottlerEntry(context_->throttler_manager(),
+                                       std::string(),
+                                       200,
+                                       3,
+                                       2000,
+                                       2.0,
+                                       0.0,
+                                       4000));
+      context_->throttler_manager()
+          ->OverrideEntryForTests(throttle_for_url_, entry);
 
       context_created_.Signal();
     }
     return context_.get();
   }
 
   virtual scoped_refptr<base::MessageLoopProxy> GetIOMessageLoopProxy() const {
     return io_message_loop_proxy_;
   }
 
@@ skipping 87 matching lines @@
   std::string data;
   EXPECT_TRUE(source->GetResponseAsString(&data));
   EXPECT_EQ(std::string(&expected[0], size), data);
   URLFetcherTest::OnURLFetchComplete(source);
 }
 
 void URLFetcherEmptyPostTest::CreateFetcher(const GURL& url) {
   fetcher_ = new URLFetcherImpl(url, URLFetcher::POST, this);
   fetcher_->SetRequestContext(new TestURLRequestContextGetter(
       io_message_loop_proxy()));
-  fetcher_->SetUploadData("text/plain", "");
+  fetcher_->SetUploadData("text/plain", std::string());
   fetcher_->Start();
 }
 
 void URLFetcherEmptyPostTest::OnURLFetchComplete(const URLFetcher* source) {
   EXPECT_TRUE(source->GetStatus().is_success());
   EXPECT_EQ(200, source->GetResponseCode());  // HTTP OK
 
   std::string data;
   EXPECT_TRUE(source->GetResponseAsString(&data));
   EXPECT_TRUE(data.empty());
@@ skipping 589 matching lines @@
   TestServer test_server(TestServer::TYPE_HTTP,
                          TestServer::kLocalhost,
                          base::FilePath(kDocRoot));
   ASSERT_TRUE(test_server.Start());
 
   GURL url(test_server.GetURL("defaultresponse"));
 
   // Registers an entry for test url. It only allows 3 requests to be sent
   // in 200 milliseconds.
   scoped_refptr<URLRequestThrottlerEntry> entry(
-      new URLRequestThrottlerEntry(
-          request_context()->throttler_manager(),
-          "", 200, 3, 1, 2.0, 0.0, 256));
+      new URLRequestThrottlerEntry(request_context()->throttler_manager(),
+                                   std::string(),
+                                   200,
+                                   3,
+                                   1,
+                                   2.0,
+                                   0.0,
+                                   256));
   request_context()->throttler_manager()->OverrideEntryForTests(url, entry);
 
   CreateFetcher(url);
 
   MessageLoop::current()->Run();
 }
 
 TEST_F(URLFetcherProtectTest, ServerUnavailable) {
   TestServer test_server(TestServer::TYPE_HTTP,
                          TestServer::kLocalhost,
                          base::FilePath(kDocRoot));
   ASSERT_TRUE(test_server.Start());
 
   GURL url(test_server.GetURL("files/server-unavailable.html"));
 
   // Registers an entry for test url. The backoff time is calculated by:
   //     new_backoff = 2.0 * old_backoff + 0
   // and maximum backoff time is 256 milliseconds.
   // Maximum retries allowed is set to 11.
   scoped_refptr<URLRequestThrottlerEntry> entry(
-      new URLRequestThrottlerEntry(
-          request_context()->throttler_manager(),
-          "", 200, 3, 1, 2.0, 0.0, 256));
+      new URLRequestThrottlerEntry(request_context()->throttler_manager(),
+                                   std::string(),
+                                   200,
+                                   3,
+                                   1,
+                                   2.0,
+                                   0.0,
+                                   256));
   request_context()->throttler_manager()->OverrideEntryForTests(url, entry);
 
   CreateFetcher(url);
 
   MessageLoop::current()->Run();
 }
 
 TEST_F(URLFetcherProtectTestPassedThrough, ServerUnavailablePropagateResponse) {
   TestServer test_server(TestServer::TYPE_HTTP,
                          TestServer::kLocalhost,
                          base::FilePath(kDocRoot));
   ASSERT_TRUE(test_server.Start());
 
   GURL url(test_server.GetURL("files/server-unavailable.html"));
 
   // Registers an entry for test url. The backoff time is calculated by:
   //     new_backoff = 2.0 * old_backoff + 0
   // and maximum backoff time is 150000 milliseconds.
   // Maximum retries allowed is set to 11.
   scoped_refptr<URLRequestThrottlerEntry> entry(
-      new URLRequestThrottlerEntry(
-          request_context()->throttler_manager(),
-          "", 200, 3, 100, 2.0, 0.0, 150000));
+      new URLRequestThrottlerEntry(request_context()->throttler_manager(),
+                                   std::string(),
+                                   200,
+                                   3,
+                                   100,
+                                   2.0,
+                                   0.0,
+                                   150000));
   // Total time if *not* for not doing automatic backoff would be 150s.
   // In reality it should be "as soon as server responds".
   request_context()->throttler_manager()->OverrideEntryForTests(url, entry);
 
   CreateFetcher(url);
 
   MessageLoop::current()->Run();
 }
 
 TEST_F(URLFetcherBadHTTPSTest, BadHTTPSTest) {
@@ skipping 36 matching lines @@
                          TestServer::kLocalhost,
                          base::FilePath(kDocRoot));
   ASSERT_TRUE(test_server.Start());
 
   GURL url(test_server.GetURL("files/server-unavailable.html"));
 
   // Register an entry for test url.
   // Using a sliding window of 4 seconds, and max of 1 request, under a fast
   // run we expect to have a 4 second delay when posting the Start task.
   scoped_refptr<URLRequestThrottlerEntry> entry(
-      new URLRequestThrottlerEntry(
-          request_context()->throttler_manager(),
-          "", 4000, 1, 2000, 2.0, 0.0, 4000));
+      new URLRequestThrottlerEntry(request_context()->throttler_manager(),
+                                   std::string(),
+                                   4000,
+                                   1,
+                                   2000,
+                                   2.0,
+                                   0.0,
+                                   4000));
   request_context()->throttler_manager()->OverrideEntryForTests(url, entry);
   // Fake that a request has just started.
   entry->ReserveSendingTimeForNextRequest(base::TimeTicks());
 
   // The next request we try to send will be delayed by ~4 seconds.
   // The slower the test runs, the less the delay will be (since it takes the
   // time difference from now).
 
   base::Thread t("URLFetcher test thread");
   ASSERT_TRUE(t.Start());
@@ skipping 187 matching lines @@
   MessageLoop::current()->Run();  // OnURLFetchComplete() will Quit().
 
   MessageLoop::current()->RunUntilIdle();
   ASSERT_FALSE(file_util::PathExists(file_path_))
       << file_path_.value() << " not removed.";
 }
 
 }  // namespace
 
 }  // namespace net