Rewrite std::string("") to std::string(), Linux edition.

net/cookies/cookie_monster_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cookies/cookie_store_unittest.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
@@ skipping 215 matching lines @@
                                           base::Time(), false, false));
     EXPECT_TRUE(this->SetCookieWithDetails(cm, url_top_level_domain_plus_2,
                                           "dom_2", "X", ".math.harvard.edu",
                                            "/", base::Time(), false, false));
     EXPECT_TRUE(this->SetCookieWithDetails(cm, url_top_level_domain_plus_3,
                                           "dom_3", "X",
                                           ".bourbaki.math.harvard.edu", "/",
                                           base::Time(), false, false));
 
     // Host cookies
-    EXPECT_TRUE(this->SetCookieWithDetails(cm, url_top_level_domain_plus_1,
-                                          "host_1", "X", "", "/",
-                                          base::Time(), false, false));
-    EXPECT_TRUE(this->SetCookieWithDetails(cm, url_top_level_domain_plus_2,
-                                          "host_2", "X", "", "/",
-                                          base::Time(), false, false));
-    EXPECT_TRUE(this->SetCookieWithDetails(cm, url_top_level_domain_plus_3,
-                                          "host_3", "X", "", "/",
-                                          base::Time(), false, false));
+    EXPECT_TRUE(this->SetCookieWithDetails(cm,
+                                           url_top_level_domain_plus_1,
+                                           "host_1",
+                                           "X",
+                                           std::string(),
+                                           "/",
+                                           base::Time(),
+                                           false,
+                                           false));
+    EXPECT_TRUE(this->SetCookieWithDetails(cm,
+                                           url_top_level_domain_plus_2,
+                                           "host_2",
+                                           "X",
+                                           std::string(),
+                                           "/",
+                                           base::Time(),
+                                           false,
+                                           false));
+    EXPECT_TRUE(this->SetCookieWithDetails(cm,
+                                           url_top_level_domain_plus_3,
+                                           "host_3",
+                                           "X",
+                                           std::string(),
+                                           "/",
+                                           base::Time(),
+                                           false,
+                                           false));
 
     // Http_only cookie
-    EXPECT_TRUE(this->SetCookieWithDetails(cm, url_top_level_domain_plus_2,
-                                          "httpo_check", "X", "", "/",
-                                          base::Time(), false, true));
+    EXPECT_TRUE(this->SetCookieWithDetails(cm,
+                                           url_top_level_domain_plus_2,
+                                           "httpo_check",
+                                           "X",
+                                           std::string(),
+                                           "/",
+                                           base::Time(),
+                                           false,
+                                           true));
 
     // Secure cookies
     EXPECT_TRUE(this->SetCookieWithDetails(cm,
                                           url_top_level_domain_plus_2_secure,
                                          "sec_dom", "X", ".math.harvard.edu",
                                          "/", base::Time(), true, false));
     EXPECT_TRUE(this->SetCookieWithDetails(cm,
-                                          url_top_level_domain_plus_2_secure,
-                                          "sec_host", "X", "", "/",
-                                          base::Time(), true, false));
+                                           url_top_level_domain_plus_2_secure,
+                                           "sec_host",
+                                           "X",
+                                           std::string(),
+                                           "/",
+                                           base::Time(),
+                                           true,
+                                           false));
 
     // Domain path cookies
     EXPECT_TRUE(this->SetCookieWithDetails(cm, url_top_level_domain_plus_2,
                                           "dom_path_1", "X",
                                           ".math.harvard.edu", "/dir1",
                                           base::Time(), false, false));
     EXPECT_TRUE(this->SetCookieWithDetails(cm, url_top_level_domain_plus_2,
                                           "dom_path_2", "X",
                                           ".math.harvard.edu", "/dir1/dir2",
                                           base::Time(), false, false));
 
     // Host path cookies
-    EXPECT_TRUE(this->SetCookieWithDetails(cm, url_top_level_domain_plus_2,
-                                          "host_path_1", "X",
-                                          "", "/dir1",
-                                          base::Time(), false, false));
-    EXPECT_TRUE(this->SetCookieWithDetails(cm, url_top_level_domain_plus_2,
-                                          "host_path_2", "X",
-                                          "", "/dir1/dir2",
-                                          base::Time(), false, false));
+    EXPECT_TRUE(this->SetCookieWithDetails(cm,
+                                           url_top_level_domain_plus_2,
+                                           "host_path_1",
+                                           "X",
+                                           std::string(),
+                                           "/dir1",
+                                           base::Time(),
+                                           false,
+                                           false));
+    EXPECT_TRUE(this->SetCookieWithDetails(cm,
+                                           url_top_level_domain_plus_2,
+                                           "host_path_2",
+                                           "X",
+                                           std::string(),
+                                           "/dir1/dir2",
+                                           base::Time(),
+                                           false,
+                                           false));
 
     EXPECT_EQ(13U, this->GetAllCookies(cm).size());
   }
 
   Time GetFirstCookieAccessDate(CookieMonster* cm) {
     const CookieList all_cookies(this->GetAllCookies(cm));
     return all_cookies.front().LastAccessDate();
   }
 
   bool FindAndDeleteCookie(CookieMonster* cm,
@@ skipping 1908 matching lines @@
   scoped_refptr<CookieMonster> cm(new CookieMonster(store, NULL));
 
   // Add a cookie.
   EXPECT_TRUE(SetCookie(cm, url_google_,
                         "A=B; expires=Mon, 18-Apr-22 22:50:13 GMT"));
   this->MatchCookieLines("A=B", GetCookies(cm, url_google_));
   ASSERT_EQ(1u, store->commands().size());
   EXPECT_EQ(CookieStoreCommand::ADD, store->commands()[0].type);
   // Remove it.
   EXPECT_TRUE(SetCookie(cm, url_google_,"A=B; max-age=0"));
-  this->MatchCookieLines("", GetCookies(cm, url_google_));
+  this->MatchCookieLines(std::string(), GetCookies(cm, url_google_));
   ASSERT_EQ(2u, store->commands().size());
   EXPECT_EQ(CookieStoreCommand::REMOVE, store->commands()[1].type);
 
   // Add a cookie.
   EXPECT_TRUE(SetCookie(cm, url_google_,
                         "A=B; expires=Mon, 18-Apr-22 22:50:13 GMT"));
   this->MatchCookieLines("A=B", GetCookies(cm, url_google_));
   ASSERT_EQ(3u, store->commands().size());
   EXPECT_EQ(CookieStoreCommand::ADD, store->commands()[2].type);
   // Overwrite it.
   EXPECT_TRUE(SetCookie(cm, url_google_,
                         "A=Foo; expires=Mon, 18-Apr-22 22:50:14 GMT"));
   this->MatchCookieLines("A=Foo", GetCookies(cm, url_google_));
   ASSERT_EQ(5u, store->commands().size());
   EXPECT_EQ(CookieStoreCommand::REMOVE, store->commands()[3].type);
   EXPECT_EQ(CookieStoreCommand::ADD, store->commands()[4].type);
 
   // Create some non-persistent cookies and check that they don't go to the
   // persistent storage.
   EXPECT_TRUE(SetCookie(cm, url_google_, "B=Bar"));
   this->MatchCookieLines("A=Foo; B=Bar", GetCookies(cm, url_google_));
   EXPECT_EQ(5u, store->commands().size());
 }
 
 }  // namespace net