Rewrite std::string("") to std::string(), Linux edition.

google_apis/gaia/gaia_auth_fetcher_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // A complete set of unit tests for GaiaAuthFetcher.
 // Originally ported from GoogleAuthenticator tests.
 
 #include <string>
 
 #include "base/json/json_reader.h"
@@ skipping 293 matching lines @@
   MockFetcher mock_fetcher(
       client_login_source_, status, net::HTTP_FORBIDDEN, cookies_, data,
       net::URLFetcher::GET, &auth);
   auth.OnURLFetchComplete(&mock_fetcher);
 }
 
 TEST_F(GaiaAuthFetcherTest, ParseRequest) {
   RunParsingTest("SID=sid\nLSID=lsid\nAuth=auth\n", "sid", "lsid", "auth");
   RunParsingTest("LSID=lsid\nSID=sid\nAuth=auth\n", "sid", "lsid", "auth");
   RunParsingTest("SID=sid\nLSID=lsid\nAuth=auth", "sid", "lsid", "auth");
-  RunParsingTest("SID=sid\nAuth=auth\n", "sid", "", "auth");
-  RunParsingTest("LSID=lsid\nAuth=auth\n", "", "lsid", "auth");
-  RunParsingTest("\nAuth=auth\n", "", "", "auth");
-  RunParsingTest("SID=sid", "sid", "", "");
+  RunParsingTest("SID=sid\nAuth=auth\n", "sid", std::string(), "auth");
+  RunParsingTest("LSID=lsid\nAuth=auth\n", std::string(), "lsid", "auth");
+  RunParsingTest("\nAuth=auth\n", std::string(), std::string(), "auth");
+  RunParsingTest("SID=sid", "sid", std::string(), std::string());
 }
 
 TEST_F(GaiaAuthFetcherTest, ParseErrorRequest) {
   RunErrorParsingTest("Url=U\n"
                       "Error=E\n"
                       "CaptchaToken=T\n"
                       "CaptchaUrl=C\n", "E", "U", "C", "T");
   RunErrorParsingTest("CaptchaToken=T\n"
                       "Error=E\n"
                       "Url=U\n"
@@ skipping 253 matching lines @@
   net::TestURLFetcherFactory factory;
 
   GaiaAuthFetcher auth(&consumer, std::string(),
       profile_.GetRequestContext());
   auth.StartIssueAuthToken("sid", "lsid", "service");
 
   EXPECT_TRUE(auth.HasPendingFetch());
   MockFetcher mock_fetcher(
       issue_auth_token_source_,
       net::URLRequestStatus(net::URLRequestStatus::SUCCESS, 0),
-      net::HTTP_FORBIDDEN, cookies_, "", net::URLFetcher::GET, &auth);
+      net::HTTP_FORBIDDEN,
+      cookies_,
+      std::string(),
+      net::URLFetcher::GET,
+      &auth);
   auth.OnURLFetchComplete(&mock_fetcher);
   EXPECT_FALSE(auth.HasPendingFetch());
 }
 
 TEST_F(GaiaAuthFetcherTest, OAuthLoginTokenSuccess) {
   MockGaiaConsumer consumer;
   EXPECT_CALL(consumer, OnClientOAuthSuccess(
       GaiaAuthConsumer::ClientOAuthResult("rt1", "at1", 3600))).Times(1);
 
   net::TestURLFetcherFactory factory;
   GaiaAuthFetcher auth(&consumer, std::string(),
                        profile_.GetRequestContext());
   auth.StartLsoForOAuthLoginTokenExchange("lso_token");
   net::TestURLFetcher* fetcher = factory.GetFetcherByID(0);
   EXPECT_TRUE(NULL != fetcher);
   EXPECT_EQ(net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SAVE_COOKIES,
             fetcher->GetLoadFlags());
 
   net::ResponseCookies cookies;
   cookies.push_back(kGetAuthCodeValidCookie);
   EXPECT_TRUE(auth.HasPendingFetch());
   MockFetcher mock_fetcher1(
       client_login_to_oauth2_source_,
       net::URLRequestStatus(net::URLRequestStatus::SUCCESS, 0),
-      net::HTTP_OK, cookies, "",
-      net::URLFetcher::POST, &auth);
+      net::HTTP_OK,
+      cookies,
+      std::string(),
+      net::URLFetcher::POST,
+      &auth);
   auth.OnURLFetchComplete(&mock_fetcher1);
   EXPECT_TRUE(auth.HasPendingFetch());
   MockFetcher mock_fetcher2(
       oauth2_token_source_,
       net::URLRequestStatus(net::URLRequestStatus::SUCCESS, 0),
       net::HTTP_OK, cookies_, kGetTokenPairValidResponse,
       net::URLFetcher::POST, &auth);
   auth.OnURLFetchComplete(&mock_fetcher2);
   EXPECT_FALSE(auth.HasPendingFetch());
 }
@@ skipping 17 matching lines @@
   net::TestURLFetcherFactory factory;
   GaiaAuthFetcher auth(&consumer, std::string(),
                        profile_.GetRequestContext());
   auth.StartLsoForOAuthLoginTokenExchange("lso_token");
 
   net::ResponseCookies cookies;
   EXPECT_TRUE(auth.HasPendingFetch());
   MockFetcher mock_fetcher(
       client_login_to_oauth2_source_,
       net::URLRequestStatus(net::URLRequestStatus::SUCCESS, 0),
-      net::HTTP_FORBIDDEN, cookies, "",
-      net::URLFetcher::POST, &auth);
+      net::HTTP_FORBIDDEN,
+      cookies,
+      std::string(),
+      net::URLFetcher::POST,
+      &auth);
   auth.OnURLFetchComplete(&mock_fetcher);
   EXPECT_FALSE(auth.HasPendingFetch());
 }
 
 TEST_F(GaiaAuthFetcherTest, OAuthLoginTokenOAuth2TokenPairFailure) {
   MockGaiaConsumer consumer;
   EXPECT_CALL(consumer, OnClientOAuthFailure(_))
       .Times(1);
 
   net::TestURLFetcherFactory factory;
   GaiaAuthFetcher auth(&consumer, std::string(),
                        profile_.GetRequestContext());
   auth.StartLsoForOAuthLoginTokenExchange("lso_token");
 
   net::ResponseCookies cookies;
   cookies.push_back(kGetAuthCodeValidCookie);
   EXPECT_TRUE(auth.HasPendingFetch());
   MockFetcher mock_fetcher1(
       client_login_to_oauth2_source_,
       net::URLRequestStatus(net::URLRequestStatus::SUCCESS, 0),
-      net::HTTP_OK, cookies, "",
-      net::URLFetcher::POST, &auth);
+      net::HTTP_OK,
+      cookies,
+      std::string(),
+      net::URLFetcher::POST,
+      &auth);
   auth.OnURLFetchComplete(&mock_fetcher1);
   EXPECT_TRUE(auth.HasPendingFetch());
   MockFetcher mock_fetcher2(
       oauth2_token_source_,
       net::URLRequestStatus(net::URLRequestStatus::SUCCESS, 0),
-      net::HTTP_FORBIDDEN, cookies_, "",
-      net::URLFetcher::POST, &auth);
+      net::HTTP_FORBIDDEN,
+      cookies_,
+      std::string(),
+      net::URLFetcher::POST,
+      &auth);
   auth.OnURLFetchComplete(&mock_fetcher2);
   EXPECT_FALSE(auth.HasPendingFetch());
 }
 
 TEST_F(GaiaAuthFetcherTest, MergeSessionSuccess) {
   MockGaiaConsumer consumer;
   EXPECT_CALL(consumer, OnMergeSessionSuccess("<html></html>"))
       .Times(1);
 
   net::TestURLFetcherFactory factory;
@@ skipping 107 matching lines @@
   factory.set_results(kClientOAuthValidResponse);
 
   MockGaiaConsumer consumer;
   EXPECT_CALL(consumer, OnClientOAuthSuccess(
       GaiaAuthConsumer::ClientOAuthResult("rt1", "at1", 3600))).Times(1);
 
   GaiaAuthFetcher auth(&consumer, "tests", profile_.GetRequestContext());
   std::vector<std::string> scopes;
   scopes.push_back(GaiaUrls::GetInstance()->oauth1_login_scope());
   scopes.push_back("https://some.other.scope.com");
-  auth.StartClientOAuth("username", "password", scopes, "", "en");
+  auth.StartClientOAuth("username", "password", scopes, std::string(), "en");
 
   std::string expected_text = base::StringPrintf(
       "{"
       "\"email\": \"username\","
       "\"password\": \"password\","
       "\"scopes\": [\"https://www.google.com/accounts/OAuthLogin\","
       "             \"https://some.other.scope.com\"],"
       "\"oauth2_client_id\": \"%s\","
       "\"friendly_device_name\": \"tests\","
       "\"accepts_challenges\": [\"Captcha\", \"TwoStep\"],"
@@ skipping 11 matching lines @@
   MockURLFetcherFactory<MockFetcher> factory;
   factory.set_results(kClientOAuthValidResponse);
 
   MockGaiaConsumer consumer;
   EXPECT_CALL(consumer, OnClientOAuthSuccess(
       GaiaAuthConsumer::ClientOAuthResult("rt1", "at1", 3600))).Times(1);
 
   GaiaAuthFetcher auth(&consumer, "te\"sts", profile_.GetRequestContext());
   std::vector<std::string> scopes;
   scopes.push_back("https://some.\"other.scope.com");
-  auth.StartClientOAuth("user\"name", "pass\"word", scopes, "", "e\"n");
+  auth.StartClientOAuth(
+      "user\"name", "pass\"word", scopes, std::string(), "e\"n");
 
   std::string expected_text = base::StringPrintf(
       "{"
       "\"email\": \"user\\\"name\","
       "\"password\": \"pass\\\"word\","
       "\"scopes\": [\"https://some.\\\"other.scope.com\"],"
       "\"oauth2_client_id\": \"%s\","
       "\"friendly_device_name\": \"te\\\"sts\","
       "\"accepts_challenges\": [\"Captcha\", \"TwoStep\"],"
       "\"locale\": \"e\\\"n\","
@@ skipping 16 matching lines @@
                       "  }"
                       "}");
 
   MockGaiaConsumer consumer;
   EXPECT_CALL(consumer, OnClientOAuthFailure(_))
       .WillOnce(Invoke(ExpectBadAuth));
 
   GaiaAuthFetcher auth(&consumer, "tests", profile_.GetRequestContext());
   std::vector<std::string> scopes;
   scopes.push_back(GaiaUrls::GetInstance()->oauth1_login_scope());
-  auth.StartClientOAuth("username", "password", scopes, "", "en");
+  auth.StartClientOAuth("username", "password", scopes, std::string(), "en");
 }
 
 TEST_F(GaiaAuthFetcherTest, ClientOAuthCaptchaChallenge) {
   MockURLFetcherFactory<MockFetcher> factory;
   factory.set_success(false);
   factory.set_results("{"
                       "  \"cause\" : \"NeedsAdditional\","
                       "  \"fallback\" : {"
                       "    \"name\" : \"Terminating\","
                       "    \"url\" : \"https://www.terminating.com\""
                       "  },"
                       "  \"challenge\" : {"
                       "    \"name\" : \"Captcha\","
                       "    \"image_url\" : \"http://www.image.com/\","
                       "    \"image_width\" : 640,"
                       "    \"image_height\" : 480,"
                       "    \"audio_url\" : \"http://www.audio.com/\","
                       "    \"challenge_token\" : \"challengetokenblob\""
                       "  }"
                       "}");
 
   MockGaiaConsumer consumer;
   EXPECT_CALL(consumer, OnClientOAuthFailure(_))
       .WillOnce(Invoke(ExpectCaptchaChallenge));
 
   GaiaAuthFetcher auth(&consumer, "tests", profile_.GetRequestContext());
   std::vector<std::string> scopes;
   scopes.push_back(GaiaUrls::GetInstance()->oauth1_login_scope());
-  auth.StartClientOAuth("username", "password", scopes, "", "en");
+  auth.StartClientOAuth("username", "password", scopes, std::string(), "en");
 }
 
 TEST_F(GaiaAuthFetcherTest, ClientOAuthTwoFactorChallenge) {
   MockURLFetcherFactory<MockFetcher> factory;
   factory.set_success(false);
   factory.set_results("{"
                       "  \"cause\" : \"NeedsAdditional\","
                       "  \"fallback\" : {"
                       "    \"name\" : \"Terminating\","
                       "    \"url\" : \"https://www.terminating.com\""
                       "  },"
                       "  \"challenge\" : {"
                       "    \"name\" : \"TwoStep\","
                       "    \"prompt_text\" : \"prompt_text\","
                       "    \"alternate_text\" : \"alternate_text\","
                       "    \"challenge_token\" : \"challengetokenblob\","
                       "    \"field_length\" : 10"
                       "  }"
                       "}");
 
   MockGaiaConsumer consumer;
   EXPECT_CALL(consumer, OnClientOAuthFailure(_))
       .WillOnce(Invoke(ExpectTwoFactorChallenge));
 
   GaiaAuthFetcher auth(&consumer, "tests", profile_.GetRequestContext());
   std::vector<std::string> scopes;
   scopes.push_back(GaiaUrls::GetInstance()->oauth1_login_scope());
-  auth.StartClientOAuth("username", "password", scopes, "", "en");
+  auth.StartClientOAuth("username", "password", scopes, std::string(), "en");
 }
 
 TEST_F(GaiaAuthFetcherTest, ClientOAuthChallengeSuccess) {
   MockURLFetcherFactory<MockFetcher> factory;
   factory.set_results(kClientOAuthValidResponse);
 
   MockGaiaConsumer consumer;
   EXPECT_CALL(consumer, OnClientOAuthSuccess(
       GaiaAuthConsumer::ClientOAuthResult("rt1", "at1", 3600))).Times(2);
 
@@ skipping 68 matching lines @@
       .Times(1);
 
   GaiaAuthFetcher auth(&consumer, std::string(),
       profile_.GetRequestContext());
   net::URLRequestStatus status(net::URLRequestStatus::SUCCESS, 0);
   MockFetcher mock_fetcher(
       oauth_login_gurl_, status, net::HTTP_OK, cookies_, data,
       net::URLFetcher::GET, &auth);
   auth.OnURLFetchComplete(&mock_fetcher);
 }