Rewrite std::string("") to std::string(), Linux edition.

extensions/common/matcher/url_matcher_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/matcher/url_matcher.h"
 
 #include "base/string_util.h"
 #include "googleurl/src/gurl.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 229 matching lines @@
   EXPECT_NE(old_id_4, c7.string_pattern()->id());
 }
 
 TEST(URLMatcherConditionFactoryTest, TestComponentSearches) {
   GURL gurl("https://www.google.com:1234/webhp?sourceid=chrome-instant&ie=UTF-8"
       "&ion=1#hl=en&output=search&sclient=psy-ab&q=chrome%20is%20awesome");
   URLMatcherConditionFactory factory;
   std::string url = factory.CanonicalizeURLForComponentSearches(gurl);
 
   // Test host component.
-  EXPECT_TRUE(Matches(factory.CreateHostPrefixCondition(""), url));
+  EXPECT_TRUE(Matches(factory.CreateHostPrefixCondition(std::string()), url));
   EXPECT_TRUE(Matches(factory.CreateHostPrefixCondition("www.goog"), url));
   EXPECT_TRUE(
       Matches(factory.CreateHostPrefixCondition("www.google.com"), url));
   EXPECT_TRUE(
       Matches(factory.CreateHostPrefixCondition(".www.google.com"), url));
   EXPECT_FALSE(Matches(factory.CreateHostPrefixCondition("google.com"), url));
   EXPECT_FALSE(
       Matches(factory.CreateHostPrefixCondition("www.google.com/"), url));
   EXPECT_FALSE(Matches(factory.CreateHostPrefixCondition("webhp"), url));
 
-  EXPECT_TRUE(Matches(factory.CreateHostSuffixCondition(""), url));
+  EXPECT_TRUE(Matches(factory.CreateHostSuffixCondition(std::string()), url));
   EXPECT_TRUE(Matches(factory.CreateHostSuffixCondition("com"), url));
   EXPECT_TRUE(Matches(factory.CreateHostSuffixCondition(".com"), url));
   EXPECT_TRUE(
       Matches(factory.CreateHostSuffixCondition("www.google.com"), url));
   EXPECT_TRUE(
       Matches(factory.CreateHostSuffixCondition(".www.google.com"), url));
   EXPECT_FALSE(Matches(factory.CreateHostSuffixCondition("www"), url));
   EXPECT_FALSE(
       Matches(factory.CreateHostSuffixCondition("www.google.com/"), url));
   EXPECT_FALSE(Matches(factory.CreateHostSuffixCondition("webhp"), url));
 
-  EXPECT_FALSE(Matches(factory.CreateHostEqualsCondition(""), url));
+  EXPECT_FALSE(Matches(factory.CreateHostEqualsCondition(std::string()), url));
   EXPECT_FALSE(Matches(factory.CreateHostEqualsCondition("www"), url));
   EXPECT_TRUE(
       Matches(factory.CreateHostEqualsCondition("www.google.com"), url));
   EXPECT_FALSE(
       Matches(factory.CreateHostEqualsCondition("www.google.com/"), url));
 
 
   // Test path component.
-  EXPECT_TRUE(Matches(factory.CreatePathPrefixCondition(""), url));
+  EXPECT_TRUE(Matches(factory.CreatePathPrefixCondition(std::string()), url));
   EXPECT_TRUE(Matches(factory.CreatePathPrefixCondition("/web"), url));
   EXPECT_TRUE(Matches(factory.CreatePathPrefixCondition("/webhp"), url));
   EXPECT_FALSE(Matches(factory.CreatePathPrefixCondition("webhp"), url));
   EXPECT_FALSE(Matches(factory.CreatePathPrefixCondition("/webhp?"), url));
   EXPECT_FALSE(Matches(factory.CreatePathPrefixCondition("?sourceid"), url));
 
-  EXPECT_TRUE(Matches(factory.CreatePathSuffixCondition(""), url));
+  EXPECT_TRUE(Matches(factory.CreatePathSuffixCondition(std::string()), url));
   EXPECT_TRUE(Matches(factory.CreatePathSuffixCondition("webhp"), url));
   EXPECT_TRUE(Matches(factory.CreatePathSuffixCondition("/webhp"), url));
   EXPECT_FALSE(Matches(factory.CreatePathSuffixCondition("/web"), url));
   EXPECT_FALSE(Matches(factory.CreatePathSuffixCondition("/webhp?"), url));
 
   EXPECT_TRUE(Matches(factory.CreatePathEqualsCondition("/webhp"), url));
   EXPECT_FALSE(Matches(factory.CreatePathEqualsCondition("webhp"), url));
   EXPECT_FALSE(Matches(factory.CreatePathEqualsCondition("/webhp?"), url));
   EXPECT_FALSE(
       Matches(factory.CreatePathEqualsCondition("www.google.com"), url));
 
 
   // Test query component.
-  EXPECT_TRUE(Matches(factory.CreateQueryPrefixCondition(""), url));
+  EXPECT_TRUE(Matches(factory.CreateQueryPrefixCondition(std::string()), url));
   EXPECT_TRUE(Matches(factory.CreateQueryPrefixCondition("sourceid"), url));
   // The '?' at the beginning is just ignored.
   EXPECT_TRUE(Matches(factory.CreateQueryPrefixCondition("?sourceid"), url));
 
-  EXPECT_TRUE(Matches(factory.CreateQuerySuffixCondition(""), url));
+  EXPECT_TRUE(Matches(factory.CreateQuerySuffixCondition(std::string()), url));
   EXPECT_TRUE(Matches(factory.CreateQuerySuffixCondition("ion=1"), url));
   EXPECT_FALSE(Matches(factory.CreateQuerySuffixCondition("www"), url));
   // "Suffix" condition + pattern starting with '?' = "equals" condition.
   EXPECT_FALSE(Matches(factory.CreateQuerySuffixCondition(
       "?sourceid=chrome-instant&ie=UTF-8&ion="), url));
   EXPECT_TRUE(Matches(factory.CreateQuerySuffixCondition(
       "?sourceid=chrome-instant&ie=UTF-8&ion=1"), url));
 
   EXPECT_FALSE(Matches(factory.CreateQueryEqualsCondition(
       "?sourceid=chrome-instant&ie=UTF-8&ion="), url));
   EXPECT_FALSE(Matches(factory.CreateQueryEqualsCondition(
       "sourceid=chrome-instant&ie=UTF-8&ion="), url));
   EXPECT_TRUE(Matches(factory.CreateQueryEqualsCondition(
       "sourceid=chrome-instant&ie=UTF-8&ion=1"), url));
   // The '?' at the beginning is just ignored.
   EXPECT_TRUE(Matches(factory.CreateQueryEqualsCondition(
       "?sourceid=chrome-instant&ie=UTF-8&ion=1"), url));
   EXPECT_FALSE(
       Matches(factory.CreateQueryEqualsCondition("www.google.com"), url));
 
 
   // Test adjacent components
   EXPECT_TRUE(Matches(factory.CreateHostSuffixPathPrefixCondition(
       "google.com", "/webhp"), url));
-  EXPECT_TRUE(Matches(factory.CreateHostSuffixPathPrefixCondition(
-      "", "/webhp"), url));
-  EXPECT_TRUE(Matches(factory.CreateHostSuffixPathPrefixCondition(
-      "google.com", ""), url));
-  EXPECT_FALSE(Matches(factory.CreateHostSuffixPathPrefixCondition(
-      "www", ""), url));
+  EXPECT_TRUE(Matches(
+      factory.CreateHostSuffixPathPrefixCondition(std::string(), "/webhp"),
+      url));
+  EXPECT_TRUE(Matches(
+      factory.CreateHostSuffixPathPrefixCondition("google.com", std::string()),
+      url));
+  EXPECT_FALSE(Matches(
+      factory.CreateHostSuffixPathPrefixCondition("www", std::string()), url));
 
   EXPECT_TRUE(Matches(factory.CreateHostEqualsPathPrefixCondition(
       "www.google.com", "/webhp"), url));
-  EXPECT_FALSE(Matches(factory.CreateHostEqualsPathPrefixCondition(
-      "", "/webhp"), url));
+  EXPECT_FALSE(Matches(
+      factory.CreateHostEqualsPathPrefixCondition(std::string(), "/webhp"),
+      url));
   EXPECT_TRUE(Matches(factory.CreateHostEqualsPathPrefixCondition(
-      "www.google.com", ""), url));
-  EXPECT_FALSE(Matches(factory.CreateHostEqualsPathPrefixCondition(
-      "google.com", ""), url));
+                          "www.google.com", std::string()),
+                      url));
+  EXPECT_FALSE(Matches(
+      factory.CreateHostEqualsPathPrefixCondition("google.com", std::string()),
+      url));
 }
 
 TEST(URLMatcherConditionFactoryTest, TestFullSearches) {
   // The Port 443 is stripped because it is the default port for https.
   GURL gurl("https://www.google.com:443/webhp?sourceid=chrome-instant&ie=UTF-8"
       "&ion=1#hl=en&output=search&sclient=psy-ab&q=chrome%20is%20awesome");
   URLMatcherConditionFactory factory;
   std::string url = factory.CanonicalizeURLForFullSearches(gurl);
 
-  EXPECT_TRUE(Matches(factory.CreateURLPrefixCondition(""), url));
-  EXPECT_TRUE(Matches(factory.CreateURLPrefixCondition(
-      "https://www.goog"), url));
+  EXPECT_TRUE(Matches(factory.CreateURLPrefixCondition(std::string()), url));
+  EXPECT_TRUE(
+      Matches(factory.CreateURLPrefixCondition("https://www.goog"), url));
   EXPECT_TRUE(Matches(factory.CreateURLPrefixCondition(
       "https://www.google.com"), url));
   EXPECT_TRUE(Matches(factory.CreateURLPrefixCondition(
       "https://www.google.com/webhp?"), url));
   EXPECT_FALSE(Matches(factory.CreateURLPrefixCondition(
       "http://www.google.com"), url));
   EXPECT_FALSE(Matches(factory.CreateURLPrefixCondition("webhp"), url));
 
-  EXPECT_TRUE(Matches(factory.CreateURLSuffixCondition(""), url));
+  EXPECT_TRUE(Matches(factory.CreateURLSuffixCondition(std::string()), url));
   EXPECT_TRUE(Matches(factory.CreateURLSuffixCondition("ion=1"), url));
   EXPECT_FALSE(Matches(factory.CreateURLSuffixCondition("www"), url));
 
-  EXPECT_TRUE(Matches(factory.CreateURLContainsCondition(""), url));
+  EXPECT_TRUE(Matches(factory.CreateURLContainsCondition(std::string()), url));
   EXPECT_TRUE(Matches(factory.CreateURLContainsCondition("www.goog"), url));
   EXPECT_TRUE(Matches(factory.CreateURLContainsCondition("webhp"), url));
   EXPECT_TRUE(Matches(factory.CreateURLContainsCondition("?"), url));
   EXPECT_TRUE(Matches(factory.CreateURLContainsCondition("sourceid"), url));
   EXPECT_TRUE(Matches(factory.CreateURLContainsCondition("ion=1"), url));
   EXPECT_FALSE(Matches(factory.CreateURLContainsCondition(".www.goog"), url));
   EXPECT_FALSE(Matches(factory.CreateURLContainsCondition("foobar"), url));
   EXPECT_FALSE(Matches(factory.CreateURLContainsCondition("search"), url));
   EXPECT_FALSE(Matches(factory.CreateURLContainsCondition(":443"), url));
 
@@ skipping 237 matching lines @@
 
   const int kConditionSetId = 1;
   URLMatcherConditionSet::Vector insert;
   insert.push_back(make_scoped_refptr(
       new URLMatcherConditionSet(kConditionSetId, conditions)));
   matcher.AddConditionSets(insert);
   EXPECT_EQ(1u, matcher.MatchURL(url).size());
 }
 
 }  // namespace extensions