Rewrite std::string("") to std::string(), Linux edition.

dbus/message_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "dbus/message.h"
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/posix/eintr_wrapper.h"
@@ skipping 539 matching lines @@
   dbus::MessageReader reader(error_response.get());
   std::string error_message;
   ASSERT_TRUE(reader.PopString(&error_message));
   EXPECT_EQ(kErrorMessage, error_message);
 }
 
 TEST(MessageTest, GetAndSetHeaders) {
   scoped_ptr<dbus::Response> message(dbus::Response::CreateEmpty());
 
   EXPECT_EQ("", message->GetDestination());
-  EXPECT_EQ(dbus::ObjectPath(""), message->GetPath());
+  EXPECT_EQ(dbus::ObjectPath(std::string()), message->GetPath());
   EXPECT_EQ("", message->GetInterface());
   EXPECT_EQ("", message->GetMember());
   EXPECT_EQ("", message->GetErrorName());
   EXPECT_EQ("", message->GetSender());
   EXPECT_EQ(0U, message->GetSerial());
   EXPECT_EQ(0U, message->GetReplySerial());
 
   EXPECT_TRUE(message->SetDestination("org.chromium.destination"));
   EXPECT_TRUE(message->SetPath(dbus::ObjectPath("/org/chromium/path")));
   EXPECT_TRUE(message->SetInterface("org.chromium.interface"));
   EXPECT_TRUE(message->SetMember("member"));
   EXPECT_TRUE(message->SetErrorName("org.chromium.error"));
   EXPECT_TRUE(message->SetSender(":1.2"));
   message->SetSerial(123);
   message->SetReplySerial(456);
 
   EXPECT_EQ("org.chromium.destination", message->GetDestination());
   EXPECT_EQ(dbus::ObjectPath("/org/chromium/path"), message->GetPath());
   EXPECT_EQ("org.chromium.interface", message->GetInterface());
   EXPECT_EQ("member", message->GetMember());
   EXPECT_EQ("org.chromium.error", message->GetErrorName());
   EXPECT_EQ(":1.2", message->GetSender());
   EXPECT_EQ(123U, message->GetSerial());
   EXPECT_EQ(456U, message->GetReplySerial());
 }
 
 TEST(MessageTest, SetInvalidHeaders) {
   scoped_ptr<dbus::Response> message(dbus::Response::CreateEmpty());
   EXPECT_EQ("", message->GetDestination());
-  EXPECT_EQ(dbus::ObjectPath(""), message->GetPath());
+  EXPECT_EQ(dbus::ObjectPath(std::string()), message->GetPath());
   EXPECT_EQ("", message->GetInterface());
   EXPECT_EQ("", message->GetMember());
   EXPECT_EQ("", message->GetErrorName());
   EXPECT_EQ("", message->GetSender());
 
   // Empty element between periods.
   EXPECT_FALSE(message->SetDestination("org..chromium"));
   // Trailing '/' is only allowed for the root path.
   EXPECT_FALSE(message->SetPath(dbus::ObjectPath("/org/chromium/")));
   // Interface name cannot contain '/'.
   EXPECT_FALSE(message->SetInterface("org/chromium/interface"));
   // Member name cannot begin with a digit.
   EXPECT_FALSE(message->SetMember("1member"));
   // Error name cannot begin with a period.
   EXPECT_FALSE(message->SetErrorName(".org.chromium.error"));
   // Disallowed characters.
   EXPECT_FALSE(message->SetSender("?!#*"));
 
   EXPECT_EQ("", message->GetDestination());
-  EXPECT_EQ(dbus::ObjectPath(""), message->GetPath());
+  EXPECT_EQ(dbus::ObjectPath(std::string()), message->GetPath());
   EXPECT_EQ("", message->GetInterface());
   EXPECT_EQ("", message->GetMember());
   EXPECT_EQ("", message->GetErrorName());
   EXPECT_EQ("", message->GetSender());
 }
 
 TEST(MessageTest, ToString_LongString) {
   const std::string kLongString(1000, 'o');
 
   scoped_ptr<dbus::Response> message(dbus::Response::CreateEmpty());
   dbus::MessageWriter writer(message.get());
   writer.AppendString(kLongString);
 
   ASSERT_EQ("message_type: MESSAGE_METHOD_RETURN\n"
             "signature: s\n\n"
             "string \"oooooooooooooooooooooooooooooooooooooooooooooooo"
             "oooooooooooooooooooooooooooooooooooooooooooooooooooo... "
             "(1000 bytes in total)\"\n",
             message->ToString());
 }