Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: content/browser/gpu/gpu_control_list_machine_model_info_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/gpu/gpu_control_list.h" 5 #include "content/browser/gpu/gpu_control_list.h"
6 #include "testing/gtest/include/gtest/gtest.h" 6 #include "testing/gtest/include/gtest/gtest.h"
7 7
8 namespace content { 8 namespace content {
9 9
10 class MachineModelInfoTest : public testing::Test { 10 class MachineModelInfoTest : public testing::Test {
(...skipping 29 matching lines...) Expand all
40 if (version_op[j] == "between") 40 if (version_op[j] == "between")
41 version2 = "5.4"; 41 version2 = "5.4";
42 MachineModelInfo info(name_op[i], "model", 42 MachineModelInfo info(name_op[i], "model",
43 version_op[j], version1, version2); 43 version_op[j], version1, version2);
44 EXPECT_TRUE(info.IsValid()); 44 EXPECT_TRUE(info.IsValid());
45 } 45 }
46 } 46 }
47 } 47 }
48 48
49 TEST_F(MachineModelInfoTest, ModelComparison) { 49 TEST_F(MachineModelInfoTest, ModelComparison) {
50 MachineModelInfo info("=", "model_a", 50 MachineModelInfo info("=", "model_a", ">", "3.4", std::string());
51 ">", "3.4", "");
52 EXPECT_TRUE(info.Contains("model_a", "4")); 51 EXPECT_TRUE(info.Contains("model_a", "4"));
53 EXPECT_FALSE(info.Contains("model_b", "4")); 52 EXPECT_FALSE(info.Contains("model_b", "4"));
54 EXPECT_FALSE(info.Contains("model_a", "3.2")); 53 EXPECT_FALSE(info.Contains("model_a", "3.2"));
55 } 54 }
56 55
57 } // namespace content 56 } // namespace content
58 57
OLDNEW
« no previous file with comments | « content/browser/gpu/gpu_control_list.cc ('k') | content/browser/gpu/gpu_control_list_number_info_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698