Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Side by Side Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/browser_plugin/browser_plugin_guest.h" 5 #include "content/browser/browser_plugin/browser_plugin_guest.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/message_loop.h" 9 #include "base/message_loop.h"
10 #include "base/string_util.h" 10 #include "base/string_util.h"
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 RenderViewHost* render_view_host, 85 RenderViewHost* render_view_host,
86 int url_request_id) { 86 int url_request_id) {
87 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); 87 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
88 88
89 int render_process_id = render_view_host->GetProcess()->GetID(); 89 int render_process_id = render_view_host->GetProcess()->GetID();
90 GlobalRequestID global_id(render_process_id, url_request_id); 90 GlobalRequestID global_id(render_process_id, url_request_id);
91 net::URLRequest* url_request = 91 net::URLRequest* url_request =
92 ResourceDispatcherHostImpl::Get()->GetURLRequest(global_id); 92 ResourceDispatcherHostImpl::Get()->GetURLRequest(global_id);
93 if (url_request) 93 if (url_request)
94 return url_request->url().possibly_invalid_spec(); 94 return url_request->url().possibly_invalid_spec();
95 return ""; 95 return std::string();
96 } 96 }
97 97
98 } 98 }
99 99
100 class BrowserPluginGuest::EmbedderRenderViewHostObserver 100 class BrowserPluginGuest::EmbedderRenderViewHostObserver
101 : public RenderViewHostObserver { 101 : public RenderViewHostObserver {
102 public: 102 public:
103 explicit EmbedderRenderViewHostObserver(BrowserPluginGuest* guest) 103 explicit EmbedderRenderViewHostObserver(BrowserPluginGuest* guest)
104 : RenderViewHostObserver( 104 : RenderViewHostObserver(
105 guest->embedder_web_contents()->GetRenderViewHost()), 105 guest->embedder_web_contents()->GetRenderViewHost()),
(...skipping 1198 matching lines...) Expand 10 before | Expand all | Expand 10 after
1304 base::Value::CreateStringValue(request_method)); 1304 base::Value::CreateStringValue(request_method));
1305 request_info.Set(browser_plugin::kURL, base::Value::CreateStringValue(url)); 1305 request_info.Set(browser_plugin::kURL, base::Value::CreateStringValue(url));
1306 1306
1307 SendMessageToEmbedder( 1307 SendMessageToEmbedder(
1308 new BrowserPluginMsg_RequestPermission(instance_id(), 1308 new BrowserPluginMsg_RequestPermission(instance_id(),
1309 BrowserPluginPermissionTypeDownload, permission_request_id, 1309 BrowserPluginPermissionTypeDownload, permission_request_id,
1310 request_info)); 1310 request_info));
1311 } 1311 }
1312 1312
1313 } // namespace content 1313 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698